Provide utility to create shape for provided marker - #22977
Draft
linev wants to merge 4 commits into
Draft
Conversation
linev
marked this pull request as draft
July 31, 2026 13:31
linev
force-pushed
the
marker_shape
branch
2 times, most recently
from
July 31, 2026 13:55
87737ac to
e662b27
Compare
Test Results 23 files 23 suites 3d 14h 2m 43s ⏱️ For more details on these failures, see this check. Results for commit e662b27. |
couet
approved these changes
Aug 3, 2026
Member
Author
|
It is still draft, I want to use introduced method in all other places - MacOS, GL, SVG, ... |
Better format header and implementation files
For configured marker style and size returns marker shape - dot, circle, fillcircle, polyline, fillarea, segments. Such method should be used in all graphical classes where marker should be painted
Replace same code, direcly cast TPoint to XPoint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement in central place functionality to create points which are necessary to paint marker.
Step by step use this functionality in different places like TGX11 or TGLPadPainter (there are 9 of such places)