Import from Zip archive

[ahlstromjc]

BPO	492105
Nosy	@gvanrossum, @loewis, @pfmoore
Files	dashc.diff: diff -c version of the patch (Mar15, 2002) dashc-2.diff: Partially fixed diff import.c.diff: diff -c import.c versus Python-2.2.1 import.c.diff: diff -c import.c versus CVS 8-15-2002

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2002-11-29.11:38:15.000>
created_at = <Date 2001-12-12.17:21:07.000>
labels = ['interpreter-core']
title = 'Import from Zip archive'
updated_at = <Date 2002-11-29.11:38:15.000>
user = 'https://bugs.python.org/ahlstromjc'

bugs.python.org fields:

activity = <Date 2002-11-29.11:38:15.000>
actor = 'paul.moore'
assignee = 'nnorwitz'
closed = True
closed_date = None
closer = None
components = ['Interpreter Core']
creation = <Date 2001-12-12.17:21:07.000>
creator = 'ahlstromjc'
dependencies = []
files = ['3836', '3837', '3838', '3839']
hgrepos = []
issue_num = 492105
keywords = ['patch']
message_count = 26.0
messages = ['38433', '38434', '38435', '38436', '38437', '38438', '38439', '38440', '38441', '38442', '38443', '38444', '38445', '38446', '38447', '38448', '38449', '38450', '38451', '38452', '38453', '38454', '38455', '38456', '38457', '38458']
nosy_count = 6.0
nosy_names = ['gvanrossum', 'loewis', 'jhylton', 'nnorwitz', 'paul.moore', 'ahlstromjc']
pr_nums = []
priority = 'normal'
resolution = 'out of date'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue492105'
versions = ['Python 2.3']

[ahlstromjc]

This is the "final" patch to support imports from zip
archives, and directory caching using os.listdir(). It
replaces patch 483466 and 476047. It is a separate
patch since I can't delete file attachments. It adds
support for importing from "" and from relative paths.

[ahlstromjc]

Logged In: YES
user_id=64929

I still can't delete files, but I added a new file which
contains all diffs as a single file, and is made from the
current CVS tree (Mar 15, 2002).

[ahlstromjc]

Logged In: YES
user_id=64929

I added a diff -c version of the patch.

[jhylton]

Logged In: YES
user_id=31392

Deleteing the old diffs that Jim couldn't delete.

[loewis]

Logged In: YES
user_id=21627

Is this patch ready to be applied?

[gvanrossum]

Logged In: YES
user_id=6380

Sigh. We waited too long for this one, and now the patch is
hopelessly out of date. I managed to fix most of the
failing hunks, but the remaining hunk that fails (#11 in
import.c) is a whopper: the saved import.c.rej is 270 lines
long.

I'm going to sleep on that, but I could use some help.

In the mean time, I'm uploading an edited version of
dashc.diff to help the next person.

[nnorwitz]

Logged In: YES
user_id=33168

I'm reviewed most of the updated version. Quick summary:

• strncpy() doesn't null terminate strings, this needs to
  be added
• seems to be many leaked references

Here are more details:

• strncpy(dest, str, size) doesn't guarantee the result to
  be null terminated,
  need dest[size] = '\0'; after all strncpy()s (I see a
  bunch in getpath.c)
• getpath.c:get_sys_path_0(), I think some compilers warn
  when you do char[i] = 0; (use '\0' instead)
  (there may be other places of this)
• import.c:PyImport_InitZip(), have_zlib is an alias to
  zlib and isn't really helpful/necessary
• import.c:get_path_type() can leak a reference to pyobj if
  it's an int
• import.c:add_directory_names() pylist reference is leaked
• import.c:add_zip_names(), memcmp(path+i, ".zip", 4) is
  clearer to me than path[i] == '.' ....
• import.c:add_zip_names, there's a lot of magic #s in this
  function

• "        " : leak refs when doing PyTuple_SetItem
  

I think there were other leaked references. I'll try to
spend some more time later.

[gvanrossum]

Logged In: YES
user_id=6380

Whoa... That's a lot. Neal, do you think you could come up
with a reworked version of this? That would be great!

[nnorwitz]

Logged In: YES
user_id=33168

Reassigning to me. I'll give it a shot. It will take a
while. Do I understand you correctly that your updated
patch (dashc-2) has all the necessary pieces, except for the
import hunk 11 that was rejected? And I need to get that
failed hunk from the original patch?