fix(tanstack-start): show progress through route transitions - #17579
Draft
jacobsfletch wants to merge 12 commits into
Draft
fix(tanstack-start): show progress through route transitions#17579jacobsfletch wants to merge 12 commits into
jacobsfletch wants to merge 12 commits into
Conversation
Contributor
📦 esbuild Bundle Analysis for payloadThis analysis was generated by esbuild-bundle-analyzer. 🤖
Largest pathsThese visualization shows top 20 largest paths in the bundle.Meta file: packages/next/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_shared.json, Out file: esbuild/exports/shared.js
Meta file: packages/richtext-lexical/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_shared.json, Out file: esbuild/exports/shared_optimized/index.js
DetailsNext to the size is how much the size has increased or decreased compared with the base branch of this PR.
|
This reverts commit 3e0e7c4.
jacobsfletch
commented
Aug 3, 2026
| <RouterAdapter> | ||
| <ServerFunctionsProvider serverFunction={serverFunction}> | ||
| <RouteTransitionProvider> | ||
| <RouteTransitionProvider> |
Member
Author
There was a problem hiding this comment.
We need to access route transition context within server functions
jacobsfletch
commented
Aug 3, 2026
| // Fast forward to 100% when the transition is complete | ||
| // Then fade out the progress bar directly after | ||
| setProgressToShow(1) | ||
| setProgressToShow((currentProgress) => (currentProgress === null ? null : 1)) |
Member
Author
There was a problem hiding this comment.
Avoids flashing progress for fast transitions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shows the loading indicator throughout TanStack Start admin navigations, including the time React spends resolving the next RSC view's client modules.
Requires #17569.
TanStack Router stops reporting a loading state once the route loader returns. For admin routes, that can happen before React has resolved code-split client references from the RSC payload and committed the next view, leaving part of the navigation without progress feedback.
The fix tracks both phases as one route transition:
Tests
Adds deterministic production coverage to the standalone
admin-routingsuite for preserving the current admin view during navigation and showing progress until the next view is ready. The tests block the relevant loader and client-chunk requests directly instead of relying on network throttling or timing.Removes the disabled progress-bar test from the broader admin general suite. The focused
admin-routingsuite can gradually absorb other navigation, routing, metadata, and custom-view coverage as the general suite is split into smaller configurations.Before
before.mp4
After
after.mp4