Make cancellation propagation atomic - #1613
Open
Clyraz wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses a remaining cancellation race in the coroutine cancellation propagation machinery by making cancellation “sticky” and ensuring newly-registered cancellers run immediately when a coroutine has already been cancelled.
Changes:
- Update
set_cancellerto invoke the canceller immediately when registration fails because cancellation has already occurred / is in progress. - Introduce a new sentinel state (
cancelled_ptr) and updatecancel()/revoke_canceller()to use it so cancellation remains observable for future awaits. - Refine atomic state transitions in
cancel()to avoid clobbering in-progress cancellation and to record post-cancel state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the 4th case mentioned in #1609:
I added a new state "cancelled_ptr" which will be used after cancelling.
Now the canceller will be invoked immediately if the previous value wasn't nullptr.