Skip to content

Fixing Bigtable snippets test - #6339

Closed
sduskis wants to merge 1 commit into
googleapis:masterfrom
sduskis:fix_cbt
Closed

Fixing Bigtable snippets test#6339
sduskis wants to merge 1 commit into
googleapis:masterfrom
sduskis:fix_cbt

Conversation

@sduskis

@sduskis sduskis commented Oct 30, 2018

Copy link
Copy Markdown
Contributor

The Cloud Bigtable build is currently broken. This PR fixes it.

  • Fixed instance.py references to client._instance_admin_client
  • Put a try-except around snippets.py setPolicy, which require high level permissions and specific users to be present.

- Fixed `instance.py` references to client._instance_admin_client
- Put a try-except around `snippets.py` setPolicy, which require high level permissions and specific users to be present.
@sduskis
sduskis requested a review from a team October 30, 2018 17:11
@sduskis
sduskis requested a review from crwilcox as a code owner October 30, 2018 17:11
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 30, 2018
@sduskis sduskis added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 30, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 30, 2018
@tseaver

tseaver commented Oct 30, 2018

Copy link
Copy Markdown
Contributor

@sduskis I've got a more robust fix for the get_iam_policy / set_iam_policy snippets failure in #6343.

@tseaver tseaver closed this Oct 30, 2018
@sduskis
sduskis deleted the fix_cbt branch May 9, 2019 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants