Issue VACCUM SQL directive to prevent the DB from keeping old Seeds.

[pfedan]

No description provided.

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[pfedan]

I signed it!

[googlebot]

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

[pfedan]

I'd consider this also a security issue (and if not, at least a matter of 'tidiness') to securely delete the seeds, see also the documentation of VACUUM (third bullet in the top list).

[ThomasHabets]

Is that semicolon needed? The other instances of mDatabase.execSQL don't end in semicolon.

[ThomasHabets]

I've filed this internally as b/129332125 because…

--

FYI: The version in Google Play Store / Apple App store is not the same as this opensource version. They've diverged. This opensource version is also unlikely to end up in the app stores. This open source version doesn't get much love, but I'll accept well-written pull requests. But don't expect this feature to be implemented by Google.

[ThomasHabets]

(will merge this anyway after you confirm the semicolon thingy)

[pfedan]

The semicolon is actually optional, as it is only one single command in the statement. It'll work either way. It was just a matter of habit to finalize an SQL command using ;.

I've filed this internally as b/129332125 because…

Not sure what that means. Will that change also be made in the Play Store / App Store versions?

[ThomasHabets]

Either is good. Thanks!