Skip to content

Updated firebase open crash link - #5297

Closed
aalej wants to merge 2 commits into
firebase:masterfrom
aalej:firebase-open-crash
Closed

aalej wants to merge 2 commits into
firebase:masterfrom
aalej:firebase-open-crash

Conversation

@aalej

@aalej aalej commented Dec 2, 2022

Copy link
Copy Markdown
Contributor

Description

Changed src/commands/open.ts LINKS Crash Reporting consolePath from /monitoring to /crashlytics

Updating the link produced by firebase open crash from https://console.firebase.google.com/project/<project_id>/monitoring -> https://console.firebase.google.com/project/<project_id>/crashlytics

The link https://console.firebase.google.com/project/<project_id>/monitoring redirects to https://console.firebase.google.com/project/<project_id>/overview instead of the Crashlytics dashboard

Scenarios Tested

$ firebase open crash
Opening Crash Reporting link in your default browser:
https://console.firebase.google.com/project/<project_id>/monitoring

Sample Commands

$ firebase open crash

@google-cla

google-cla Bot commented Dec 2, 2022

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Comment thread src/commands/open.ts
{ name: "Authentication: Providers", arg: "auth", consolePath: "/authentication/providers" },
{ name: "Authentication: Users", arg: "auth:users", consolePath: "/authentication/users" },
{ name: "Crash Reporting", arg: "crash", consolePath: "/monitoring" },
{ name: "Crash Reporting", arg: "crash", consolePath: "/crashlytics" },

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Base: 56.13% // Head: 56.13% // No change to project coverage 👍

Coverage data is based on head (37de3f8) compared to base (4755cb7).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5297   +/-   ##
=======================================
  Coverage   56.13%   56.13%           
=======================================
  Files         317      317           
  Lines       21505    21505           
  Branches     4388     4388           
=======================================
  Hits        12072    12072           
  Misses       8371     8371           
  Partials     1062     1062           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@aalej

aalej commented Jul 13, 2023

Copy link
Copy Markdown
Contributor Author

Closing this PR, changes are fixed in #6073

@aalej aalej closed this Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants