feat(auth): Add token verification logic for emulator mode - #419
Conversation
|
We should add integration tests for this PR, like Node.js SDK implementation. firebase/firebase-admin-node#1148 But I'm not sure how much should we add tests for this feature, and how to setup CI. any suggestions? |
hiranya911
left a comment
There was a problem hiding this comment.
Thanks for the PR @maku693. This looks pretty good overall. I've left a few comments on improving the readability a bit. Plus a couple of product questions to @yuchenshi around session cookie verification support.
…thods when in emulator mode and the emulator is unavailable
|
Thank you for reviewing! I've fixed the points you've commented. |
hiranya911
left a comment
There was a problem hiding this comment.
I'm at an LGTM.
@yuchenshi do you have any more feedback?
|
Would be awesome to get this merged in if it all looks good, as this issue is breaking my local development flow. |
|
Hi @hiranya911 and @yuchenshi, do you have any plans to release this in the near future? |
|
I've merged the PR. It will be included in the next release (possibly in another week or so). |
|
Hi all, Thank you! |
|
Will try and get it released this week. |
|
Hi. Why when using emulator it ALWAYS checks if token was revoked? It makes no sense to me. |
|
I just implemented similar logic based on the Node.js implementation as a reference, so I don't have an exact understanding of the reasons. Looking at the Node.js implementation, using |

Discussion
#409
This PR adds token verification with auth emulator for auth client, in addition to the changes introduced at #414.