[ZEPPELIN-3968] Fix wrong MySQL driver class in JDBC doc screenshot - #5368
Open
kimyenac wants to merge 1 commit into
Open
[ZEPPELIN-3968] Fix wrong MySQL driver class in JDBC doc screenshot#5368kimyenac wants to merge 1 commit into
kimyenac wants to merge 1 commit into
Conversation
### What is this PR for? The "Edit Properties" screenshot in the JDBC interpreter doc shows `default.driver` as `org.mysql.jdbc.Driver`, which is not a real class. The correct value is `com.mysql.jdbc.Driver`, which is what the property tables further down the same page already use. The screenshot is patched in place so the font rendering stays identical to the rest of the capture: the `c`, `o` and `m` glyphs are re-used from the same line of text, and the remainder of the string is shifted right by the advance-width difference between "org" and "com". No other pixel of the image changes. ### What type of PR is it? Documentation ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-3968 ### How should this be tested? Open `docs/interpreter/jdbc.md` and check the "Edit Properties" image now reads `com.mysql.jdbc.Driver`. ### Screenshots (if appropriate) ### Questions: * Does the license files need to update? No * Is there breaking changes for older versions? No * Does this needs documentation? No
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
The "Edit Properties" screenshot in the JDBC interpreter documentation shows
default.driverasorg.mysql.jdbc.Driver, which is not a real class. Following the docs as written gives aClassNotFoundException.The correct value is
com.mysql.jdbc.Driver, which is already what the property tables further down the same page use, so the screenshot was the only place left disagreeing with the rest of the doc.The screenshot is patched in place rather than recaptured. It dates from the 0.7 era, and a fresh capture would no longer match the surrounding images in the same walkthrough. To keep the font rendering identical, the
c,oandmglyphs were taken from elsewhere in the same line of text (jdbc,org,mysql), and the remainder of the string was shifted right by the advance width difference between "org" (1445/1000 em) and "com" (1889/1000 em), about 11px at this scale.A pixel by pixel comparison against the original confirms only the
default.drivervalue changed: 3,387 pixels inside x 936-1171, y 255-278. The surrounding table, the orange highlight box and the arrow annotation are untouched.What type of PR is it?
Documentation
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-3968
How should this be tested?
Open the "Files changed" tab and use the image diff on
docs/assets/themes/zeppelin/img/docs-img/edit_properties.png. Thedefault.driverrow should readcom.mysql.jdbc.Driver, everything else unchanged.The image is referenced from
docs/interpreter/jdbc.md.Screenshots (if appropriate)
Before:
default.driver=org.mysql.jdbc.DriverAfter:
default.driver=com.mysql.jdbc.DriverQuestions: