[ZEPPELIN-6477] Stop dumping stack trace on Groovy cancellation - #5364
Open
vividbaek wants to merge 1 commit into
Open
[ZEPPELIN-6477] Stop dumping stack trace on Groovy cancellation#5364vividbaek wants to merge 1 commit into
vividbaek wants to merge 1 commit into
Conversation
tbonelee
approved these changes
Aug 2, 2026
tbonelee
left a comment
Contributor
There was a problem hiding this comment.
LGTM.
For the record: Thread.dumpStack() is static, so t.dumpStack() printed the cancelling thread's stack to stderr, not the cancelled one's. No diagnostic value, and it bypassed the logger. t.interrupt() does the real work and is untouched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Remove the
Thread.dumpStack()call from Groovy paragraph cancellation because it writes an unnecessary stack trace directly to stderr.The existing
t.interrupt()call is preserved, so the paragraph cancellation behavior remains unchanged.What type of PR is it?
Improvement
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-6477
How should this be tested?
./mvnw test -pl groovyThe build completed successfully.
Screenshots (if appropriate)
Not applicable.
Questions: