[ZEPPELIN-3225] Add missing @Override annotations in zeppelin-server - #5359
Open
kimyenac wants to merge 1 commit into
Open
[ZEPPELIN-3225] Add missing @Override annotations in zeppelin-server#5359kimyenac wants to merge 1 commit into
kimyenac wants to merge 1 commit into
Conversation
The original report was about ActiveDirectoryGroupRealm, which was already covered by ZEPPELIN-5130. A scan of the whole zeppelin-server module found seven methods that still implement a supertype method without @OverRide: * five toJson() implementations of JsonSerializable (HeliumConf, NpmPackage, WebpackResult, WatcherMessage, CredentialsInfoSaving) * shouldSkipClass and shouldSkipField in JsonExclusionStrategy, which implement Gson's ExclusionStrategy Annotation only change, no behaviour change.
jongyoul
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
The original report is about missing @OverRide annotations in
ActiveDirectoryGroupRealm. Those were already added by ZEPPELIN-5130, so the
class is clean on current master.
To close out the issue with something useful, I scanned the whole
zeppelin-server module for methods that implement or override a supertype
method without the annotation, and found seven remaining cases:
toJson()implementations ofJsonSerializable(
HeliumConf,NpmPackage,WebpackResult,WatcherMessage,CredentialsInfoSaving)shouldSkipClassandshouldSkipFieldinJsonExclusionStrategy,which implement Gson's
ExclusionStrategyWhat type of PR is it?
Improvement
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-3225
How should this be tested?
Annotation only change with no behaviour change, so the compiler is the check.
./mvnw compile -pl zeppelin-serverpasses, RAT reports 0 unapproved licenses,and Checkstyle reports no new violations in the touched files.
Questions: