[fix](cloud) Fail closed on unknown MetaService response codes - #66364
Open
wyxxxcat wants to merge 1 commit into
Open
[fix](cloud) Fail closed on unknown MetaService response codes#66364wyxxxcat wants to merge 1 commit into
wyxxxcat wants to merge 1 commit into
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
wyxxxcat
force-pushed
the
fix_old_client_ms_code
branch
3 times, most recently
from
August 3, 2026 03:53
9de76ba to
d0aa93c
Compare
wyxxxcat
marked this pull request as ready for review
August 3, 2026 03:53
wyxxxcat
force-pushed
the
fix_old_client_ms_code
branch
from
August 3, 2026 03:59
d0aa93c to
aeed3c8
Compare
Collaborator
Author
|
run buildall |
gavinchou
reviewed
Aug 3, 2026
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
FE UT Coverage ReportIncrement line coverage |
wyxxxcat
force-pushed
the
fix_old_client_ms_code
branch
from
August 3, 2026 06:11
aeed3c8 to
7037019
Compare
Collaborator
Author
|
run buildall |
wyxxxcat
force-pushed
the
fix_old_client_ms_code
branch
from
August 3, 2026 06:54
7037019 to
f5606b1
Compare
wyxxxcat
force-pushed
the
fix_old_client_ms_code
branch
from
August 3, 2026 07:13
f5606b1 to
64dad43
Compare
Collaborator
Author
|
run buildall |
Contributor
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
FE UT Coverage ReportIncrement line coverage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary: Meta Service responses contain both an exact actual_code and a
legacy-compatible code. When a client recognizes the actual_code, it should use
that exact value. When actual_code is unknown, the legacy code is safe only if
it is explicitly present and non-OK. The previous logic could fall back to an
unset or OK code and incorrectly treat an unknown Meta Service error as success.
This change makes BE and FE fail closed with UNDEFINED_ERR in that case, while
preserving compatible non-OK fallbacks. It also adds a message explaining the
MS_TOO_BUSY to KV_TXN_CONFLICT conversion for legacy clients.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)