Skip to content

Administration: Fix install button icon alignment in the theme preview. - #12799

Open
t-hamano wants to merge 1 commit into
WordPress:trunkfrom
t-hamano:65601-fix-install-theme-button-size
Open

Administration: Fix install button icon alignment in the theme preview.#12799
t-hamano wants to merge 1 commit into
WordPress:trunkfrom
t-hamano:65601-fix-install-theme-button-size

Conversation

@t-hamano

@t-hamano t-hamano commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

Alternatives to wordpress.patch

This PR adopts a more restrictive approach.

Trac ticket: https://core.trac.wordpress.org/ticket/65601

Before After
before after

Use of AI Tools

None

The header button in the theme preview overlay is intentionally kept at 32px,
including on mobile viewports, while the global updating icon rule in
common.css assumes the 38px line height of a default size button. The
resulting 38px icon box pushed the spinner above the label and stretched the
button during installation, so scope a matching 30px icon line height to that
button instead of changing the global rule.

Fixes #65601.

Co-Authored-By: Claude <noreply@anthropic.com>
@github-actions

github-actions Bot commented Aug 1, 2026

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@t-hamano
t-hamano marked this pull request as ready for review August 2, 2026 07:11
@github-actions

github-actions Bot commented Aug 2, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props wildworks.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant