Update wp-coding-standards/wpcs to 3.4.1 - #368
Merged
Merged
Conversation
- Bump wpcs from ^2.0 to ^3.4.1 and dealerdirect/phpcodesniffer- composer-installer from ^0.5 to ^1.1 (the 0.x installer only supports PHP <= 7) and regenerate composer.lock. - Add the allow-plugins config; the lock predated composer's plugin security feature and modern composer refuses to run without it. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Member
Author
|
@desrosj Could I ask for your help with merging this? I don't seem to have access. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates off the WPCS 2.x pin. The old dev-dependency set had rotted enough that
composer installno longer works on modern PHP/composer, so this touches three things:^2.0to^3.4.1and regeneratescomposer.lock.dealerdirect/phpcodesniffer-composer-installerfrom^0.5to^1.1— the 0.x installer only supports PHP ≤7, which blocked resolution entirely.allow-pluginsconfig; the lock predated composer's plugin security feature and composer ≥2.2 refuses to run the installer without it.With this,
composer installandcomposer lintwork again. For reference, the restoredphpcsrun reports 254 errors / 62 warnings across 45 files — this repo has no phpcs CI, so those are informational; cleaning them up is a separate effort. (The locked phpunit^6still needs--ignore-platform-req=phpon modern PHP; also a candidate for follow-up.)Part of an org-wide sweep to get all repos onto WPCS 3.4.1.
🤖 Generated with Claude Code