perf: keep Euler 135 arithmetic integral - #14990
Open
tomatotomata wants to merge 1 commit into
Open
Conversation
Signed-off-by: ahmadalguydi <ahmadalgaidy@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
project_euler/problem_135/sol1.pyalready generatesnas a multiple offirst_term, but the inner loop converted that exact relationship to floating point on every iteration. This patch keeps the calculation integral with//for both the quotient and the division by four.The solution and its existing doctests are unchanged in behavior. The full default calculation still returns
4989.Checks:
python -m doctest -v project_euler/problem_135/sol1.pypython -m ruff check project_euler/problem_135/sol1.pypython -c "... solution() ..."->4989git diff --checkFixes #8594