Skip to content

Fix two minor logical bugs #1038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sshedi wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix two minor logical bugs #1038

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a8ddfb
match: guard sender_file_sum[-1] write when xfer_sum_len is 0
sshedi Aug 1, 2026
dd6a330
generator: remove dead NULL check after strdup in atomic_create
sshedi Aug 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions generator.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2058,8 +2058,6 @@ int atomic_create(struct file_struct *file, char *fname, const char *slnk, const
if (!skip_atomic) {
if (do_rename_at(tmpname, fname) < 0) {
char *full_tmpname = strdup(full_fname(tmpname));
if (full_tmpname == NULL)
out_of_memory("atomic_create");
rsyserr(FERROR_XFER, errno, "rename %s -> \"%s\" failed",
full_tmpname, full_fname(fname));
free(full_tmpname);
Expand Down
2 changes: 1 addition & 1 deletion match.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -449,7 +449,7 @@ void match_sums(int f, struct sum_struct *s, struct map_struct *buf, OFF_T len)
int i;
for (i = 0; i < xfer_sum_len && sender_file_sum[i] == 0; i++) {}
memset(sender_file_sum, 0, xfer_sum_len);
if (i == xfer_sum_len)
if (i == xfer_sum_len && i > 0)
sender_file_sum[i-1]++;
}

Expand Down