Bigtable: fix instance IAM methods - #6343
Merged
Merged
Conversation
Match that order in unit test testcases.
googlebot
added
the
cla: yes
This was referenced Oct 30, 2018
sduskis
approved these changes
Oct 30, 2018
parthea
pushed a commit
that referenced
this pull request
Nov 22, 2025
Refactor instance tests to mock 'instance_admin_client' directly, rather than underlying channel. Normalize instance method order, and make testcase order match. Closes #6337.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6337.
Refactor instance tests to mock 'instance_admin_client' directly, rather than underlying channel.
Normalize instance method order, and make testcase order match. For the testcase changes, it might be easier to review commit-by-commit, at least up through fa5602c.