Release 0.5.2 - #1093
Open
FlorianRappl wants to merge 63 commits into
Open
Conversation
Bumps [ws](https://github.com/websockets/ws), [engine.io](https://github.com/socketio/socket.io) and [socket.io-adapter](https://github.com/socketio/socket.io). These dependencies needed to be updated together. Updates `ws` from 8.17.1 to 8.20.1 - [Release notes](https://github.com/websockets/ws/releases) - [Commits](websockets/ws@8.17.1...8.20.1) Updates `engine.io` from 6.6.4 to 6.6.8 - [Release notes](https://github.com/socketio/socket.io/releases) - [Changelog](https://github.com/socketio/socket.io/blob/main/CHANGELOG.md) - [Commits](https://github.com/socketio/socket.io/compare/engine.io@6.6.4...engine.io@6.6.8) Updates `socket.io-adapter` from 2.5.5 to 2.5.7 - [Release notes](https://github.com/socketio/socket.io/releases) - [Changelog](https://github.com/socketio/socket.io/blob/main/CHANGELOG.md) - [Commits](https://github.com/socketio/socket.io/compare/socket.io-adapter@2.5.5...socket.io-adapter@2.5.7) --- updated-dependencies: - dependency-name: ws dependency-version: 8.20.1 dependency-type: indirect - dependency-name: engine.io dependency-version: 6.6.8 dependency-type: indirect - dependency-name: socket.io-adapter dependency-version: 2.5.7 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
…/ElectronNET.Host/ElectronHostHook/multi-8c9a216550 Bump ws, engine.io and socket.io-adapter in /src/ElectronNET.Host/ElectronHostHook
Bumps [tmp](https://github.com/raszi/node-tmp) to 0.2.7 and updates ancestor dependency [exceljs](https://github.com/exceljs/exceljs). These dependencies need to be updated together. Updates `tmp` from 0.1.0 to 0.2.7 - [Changelog](https://github.com/raszi/node-tmp/blob/master/CHANGELOG.md) - [Commits](raszi/node-tmp@v0.1.0...v0.2.7) Updates `exceljs` from 1.15.0 to 4.4.0 - [Release notes](https://github.com/exceljs/exceljs/releases) - [Commits](exceljs/exceljs@v1.15.0...v4.4.0) --- updated-dependencies: - dependency-name: tmp dependency-version: 0.2.7 dependency-type: indirect - dependency-name: exceljs dependency-version: 4.4.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [ws](https://github.com/websockets/ws), [engine.io](https://github.com/socketio/socket.io) and [socket.io-adapter](https://github.com/socketio/socket.io). These dependencies needed to be updated together. Updates `ws` from 8.18.3 to 8.20.1 - [Release notes](https://github.com/websockets/ws/releases) - [Commits](websockets/ws@8.18.3...8.20.1) Updates `engine.io` from 6.6.5 to 6.6.8 - [Release notes](https://github.com/socketio/socket.io/releases) - [Changelog](https://github.com/socketio/socket.io/blob/main/CHANGELOG.md) - [Commits](https://github.com/socketio/socket.io/compare/engine.io@6.6.5...engine.io@6.6.8) Updates `socket.io-adapter` from 2.5.6 to 2.5.7 - [Release notes](https://github.com/socketio/socket.io/releases) - [Changelog](https://github.com/socketio/socket.io/blob/main/CHANGELOG.md) - [Commits](https://github.com/socketio/socket.io/compare/socket.io-adapter@2.5.6...socket.io-adapter@2.5.7) --- updated-dependencies: - dependency-name: ws dependency-version: 8.20.1 dependency-type: indirect - dependency-name: engine.io dependency-version: 6.6.8 dependency-type: indirect - dependency-name: socket.io-adapter dependency-version: 2.5.7 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [ws](https://github.com/websockets/ws), [engine.io](https://github.com/socketio/socket.io) and [socket.io-adapter](https://github.com/socketio/socket.io). These dependencies needed to be updated together. Updates `ws` from 8.18.3 to 8.20.1 - [Release notes](https://github.com/websockets/ws/releases) - [Commits](websockets/ws@8.18.3...8.20.1) Updates `engine.io` from 6.6.5 to 6.6.8 - [Release notes](https://github.com/socketio/socket.io/releases) - [Changelog](https://github.com/socketio/socket.io/blob/main/CHANGELOG.md) - [Commits](https://github.com/socketio/socket.io/compare/engine.io@6.6.5...engine.io@6.6.8) Updates `socket.io-adapter` from 2.5.6 to 2.5.7 - [Release notes](https://github.com/socketio/socket.io/releases) - [Changelog](https://github.com/socketio/socket.io/blob/main/CHANGELOG.md) - [Commits](https://github.com/socketio/socket.io/compare/socket.io-adapter@2.5.6...socket.io-adapter@2.5.7) --- updated-dependencies: - dependency-name: ws dependency-version: 8.20.1 dependency-type: indirect - dependency-name: engine.io dependency-version: 6.6.8 dependency-type: indirect - dependency-name: socket.io-adapter dependency-version: 2.5.7 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
…/ElectronNET.WebApp/ElectronHostHook/multi-19724e71a7 Bump tmp and exceljs in /src/ElectronNET.WebApp/ElectronHostHook
…/ElectronNET.Host/multi-8c9a216550 Bump ws, engine.io and socket.io-adapter in /src/ElectronNET.Host
…/ElectronNET.WebApp/ElectronHostHook/multi-8c9a216550 Bump ws, engine.io and socket.io-adapter in /src/ElectronNET.WebApp/ElectronHostHook
…tron Add Overloads for `UseElectron`
Bumps [ws](https://github.com/websockets/ws), [engine.io](https://github.com/socketio/socket.io) and [socket.io-adapter](https://github.com/socketio/socket.io). These dependencies needed to be updated together. Updates `ws` from 8.20.1 to 8.21.0 - [Release notes](https://github.com/websockets/ws/releases) - [Commits](websockets/ws@8.20.1...8.21.0) Updates `engine.io` from 6.6.8 to 6.6.9 - [Release notes](https://github.com/socketio/socket.io/releases) - [Changelog](https://github.com/socketio/socket.io/blob/main/CHANGELOG.md) - [Commits](https://github.com/socketio/socket.io/compare/engine.io@6.6.8...engine.io@6.6.9) Updates `socket.io-adapter` from 2.5.7 to 2.5.8 - [Release notes](https://github.com/socketio/socket.io/releases) - [Changelog](https://github.com/socketio/socket.io/blob/main/CHANGELOG.md) - [Commits](https://github.com/socketio/socket.io/compare/socket.io-adapter@2.5.7...socket.io-adapter@2.5.8) --- updated-dependencies: - dependency-name: ws dependency-version: 8.21.0 dependency-type: indirect - dependency-name: engine.io dependency-version: 6.6.9 dependency-type: indirect - dependency-name: socket.io-adapter dependency-version: 2.5.8 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [js-yaml](https://github.com/nodeca/js-yaml) from 4.1.1 to 4.2.0. - [Changelog](https://github.com/nodeca/js-yaml/blob/master/CHANGELOG.md) - [Commits](nodeca/js-yaml@4.1.1...4.2.0) --- updated-dependencies: - dependency-name: js-yaml dependency-version: 4.2.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
…ost/multi-5f1280885e
…/ElectronNET.Host/multi-5f1280885e Bump ws, engine.io and socket.io-adapter in /src/ElectronNET.Host
…/ElectronNET.WebApp/ElectronHostHook/js-yaml-4.2.0 Bump js-yaml from 4.1.1 to 4.2.0 in /src/ElectronNET.WebApp/ElectronHostHook
…/ElectronNET.Host/js-yaml-4.3.0 Bump js-yaml from 4.1.1 to 4.3.0 in /src/ElectronNET.Host
Bumps [js-yaml](https://github.com/nodeca/js-yaml) from 4.1.1 to 4.3.0. - [Changelog](https://github.com/nodeca/js-yaml/blob/master/CHANGELOG.md) - [Commits](nodeca/js-yaml@4.1.1...4.3.0) --- updated-dependencies: - dependency-name: js-yaml dependency-version: 4.3.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [brace-expansion](https://github.com/juliangruber/brace-expansion) from 1.1.12 to 1.1.16. - [Release notes](https://github.com/juliangruber/brace-expansion/releases) - [Commits](juliangruber/brace-expansion@v1.1.12...v1.1.16) --- updated-dependencies: - dependency-name: brace-expansion dependency-version: 1.1.16 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
…/ElectronNET.Host/brace-expansion-1.1.16 Bump brace-expansion from 1.1.12 to 1.1.16 in /src/ElectronNET.Host
…/ElectronNET.WebApp/ElectronHostHook/js-yaml-4.3.0 Bump js-yaml from 4.1.1 to 4.3.0 in /src/ElectronNET.WebApp/ElectronHostHook
Bumps [builder-util-runtime](https://github.com/electron-userland/electron-builder/tree/HEAD/packages/builder-util-runtime) to 9.7.0 and updates ancestor dependency [electron-updater](https://github.com/electron-userland/electron-builder/tree/HEAD/packages/electron-updater). These dependencies need to be updated together. Updates `builder-util-runtime` from 9.5.1 to 9.7.0 - [Release notes](https://github.com/electron-userland/electron-builder/releases) - [Changelog](https://github.com/electron-userland/electron-builder/blob/master/packages/builder-util-runtime/CHANGELOG.md) - [Commits](https://github.com/electron-userland/electron-builder/commits/HEAD/packages/builder-util-runtime) Updates `electron-updater` from 6.8.3 to 6.8.9 - [Release notes](https://github.com/electron-userland/electron-builder/releases) - [Changelog](https://github.com/electron-userland/electron-builder/blob/master/packages/electron-updater/CHANGELOG.md) - [Commits](https://github.com/electron-userland/electron-builder/commits/electron-updater@6.8.9/packages/electron-updater) --- updated-dependencies: - dependency-name: builder-util-runtime dependency-version: 9.7.0 dependency-type: indirect - dependency-name: electron-updater dependency-version: 6.8.9 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [flatted](https://github.com/WebReflection/flatted) from 3.3.3 to 3.4.3. - [Commits](WebReflection/flatted@v3.3.3...v3.4.3) --- updated-dependencies: - dependency-name: flatted dependency-version: 3.4.3 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [socket.io-parser](https://github.com/socketio/socket.io) from 4.2.5 to 4.2.7. - [Release notes](https://github.com/socketio/socket.io/releases) - [Changelog](https://github.com/socketio/socket.io/blob/main/CHANGELOG.md) - [Commits](https://github.com/socketio/socket.io/compare/socket.io-parser@4.2.5...socket.io-parser@4.2.7) --- updated-dependencies: - dependency-name: socket.io-parser dependency-version: 4.2.7 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
- Moved Directory.Build.* barriers from nuke to root folder to cover all projects. - Added a Directory.Packages.props barrier to stop central package management. - Removed obsolete 'ManagePackageVersionsCentrally' properties.
Bug/#1084 - Visual studio loading issue
…/ElectronNET.Host/multi-32449639ce Bump builder-util-runtime and electron-updater in /src/ElectronNET.Host
…/ElectronNET.Host/socket.io-parser-4.2.7 Bump socket.io-parser from 4.2.5 to 4.2.7 in /src/ElectronNET.Host
…/ElectronNET.WebApp/ElectronHostHook/flatted-3.4.3 Bump flatted from 3.3.3 to 3.4.3 in /src/ElectronNET.WebApp/ElectronHostHook
…rm or architecture in order to avoid compile issue when used in development mode
Bug/#1091 - Fix CA1416 on AspNet project
Contributor
There was a problem hiding this comment.
Pull request overview
Release-focused update for Electron.NET 0.5.2 that refines packaging/build orchestration (electron-builder two-package.json layout + hook handling) and expands ASP.NET integration by supporting more UseElectron callback shapes.
Changes:
- Restructures electron-builder packaging to use a dev
package.jsonat the publish root and an apppackage.jsonunderapp/, plus installs runtime dependencies intoapp/node_modules. - Adds an
IAppReadyCallbackResolverabstraction and newUseElectronoverload variants (args- and DI-aware callbacks). - Fixes auth token query param handling so it isn’t appended to non-local/external URLs.
Reviewed changes
Copilot reviewed 26 out of 32 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| src/ElectronNET/build/package.template.json | Removes build config from the app package.json template (for two-package layout). |
| src/ElectronNET/build/package.dev.template.json | Adds dev package.json template holding electron-builder build configuration. |
| src/ElectronNET/build/ElectronNETRules.Project.xaml | Adds newer Electron version enum values. |
| src/ElectronNET/build/ElectronNET.LateImport.targets | Updates publish pipeline: app subfolder, hook packaging/restore, and electron-builder invocation changes. |
| src/ElectronNET/build/ElectronNET.Core.props | Introduces ElectronRuntimeIdentifier logic for build orchestration. |
| src/ElectronNET.WebApp/ElectronNET.WebApp.csproj | Updates sample package references and removes fixed RuntimeIdentifier. |
| src/ElectronNET.WebApp/ElectronHostHook/package-lock.json | Updates dev dependency lock entries for the web app hook. |
| src/ElectronNET.Samples.ElectronHostHook/ElectronNET.Samples.ElectronHostHook.csproj | Enables TS hook compilation and bumps package references. |
| src/ElectronNET.Samples.AuthMiddleware/Components/Layout/NavMenu.razor | Fixes displayed app name in navbar. |
| src/ElectronNET.Samples.AuthMiddleware/Components/App.razor | Fixes referenced generated styles bundle name. |
| src/ElectronNET.IntegrationTests/ElectronNET.IntegrationTests.csproj | Marks integration test project as a test project. |
| src/ElectronNET.Host/package.json | Updates electron-updater dependency version. |
| src/ElectronNET.Host/package-lock.json | Updates lockfile for electron-updater and related transitive deps. |
| src/ElectronNET.Host/api/browserWindows.ts | Restricts token query param injection to local URLs via URL parsing. |
| src/ElectronNET.Host/api/browserWindows.js | Compiled JS output reflecting the token-handling change. |
| src/ElectronNET.Host/api/browserWindows.js.map | Updated sourcemap for the compiled JS. |
| src/ElectronNET.ConsoleApp/ElectronNET.ConsoleApp.csproj | Updates console app package reference version. |
| src/ElectronNET.AspNet/Runtime/Services/IAppReadyCallbackResolver.cs | Adds internal interface for resolving/invoking app-ready callback. |
| src/ElectronNET.AspNet/Runtime/Services/AppReadyCallbackResolver.cs | Adds resolver implementation supporting multiple callback shapes. |
| src/ElectronNET.AspNet/Runtime/Controllers/RuntimeControllerAspNetElectronFirst.cs | Wires callback resolver into controller constructor chain. |
| src/ElectronNET.AspNet/Runtime/Controllers/RuntimeControllerAspNetDotnetFirst.cs | Wires callback resolver into controller constructor chain. |
| src/ElectronNET.AspNet/Runtime/Controllers/RuntimeControllerAspNetBase.cs | Uses resolver to invoke app-ready callback and improves warning text. |
| src/ElectronNET.AspNet/ElectronNET.AspNet.csproj | Simplifies NoWarn configuration. |
| src/ElectronNET.AspNet/API/WebHostBuilderExtensions.cs | Registers resolver in DI and adds multiple UseElectron overloads. |
| src/ElectronNET.AspNet/API/WebApplicationBuilderExtensions.cs | Adds matching WebApplicationBuilder.UseElectron overload variants. |
| src/ElectronNET.API/ElectronNetRuntime.cs | Removes global static OnAppReadyCallback storage. |
| src/common.props | Bumps repo version to 0.5.2. |
| docs/GettingStarted/Console-App.md | Updates package reference version in docs snippet. |
| Directory.Packages.props | Adds guard file to prevent unintended MSBuild imports. |
| Directory.Build.targets | Adds guard file to prevent unintended MSBuild imports. |
| Directory.Build.props | Adds guard file to prevent unintended MSBuild imports. |
| Changelog.md | Adds 0.5.2 release notes (token URL fix + UseElectron variants). |
Files not reviewed (3)
- src/ElectronNET.Host/api/browserWindows.js: Generated file
- src/ElectronNET.Host/package-lock.json: Generated file
- src/ElectronNET.WebApp/ElectronHostHook/package-lock.json: Generated file
Suppressed comments (1)
src/ElectronNET/build/ElectronNET.LateImport.targets:652
- ElectronPublishApp’s electron-builder invocation only appends --$(ElectronPlatform) and --$(ElectronArch) under the WSL path. On non-WSL builds this drops the explicit target platform/arch flags, so overrides via $(ElectronRuntimeIdentifier) (e.g. win-x86 on a Windows x64 machine) won’t be honored.
<_NpxCmd>npx electron-builder --config=./$(ElectronBuilderJson)</_NpxCmd>
<_NpxCmd Condition="'$(IsLinuxWsl)' == 'true'">$(_NpxCmd) --$(ElectronPlatform)</_NpxCmd>
<_NpxCmd Condition="'$(IsLinuxWsl)' == 'true'">$(_NpxCmd) --$(ElectronArch)</_NpxCmd>
<_NpxCmd>$(_NpxCmd) -c.electronVersion=$(ElectronVersion) -c.directories.output "$(ElectronPublishUrlFullPath)" $(ElectronPaParams)</_NpxCmd>
<_NpxCmd Condition="'$(IsLinuxWsl)' == 'true'">wsl bash -ic '$(_NpxCmd)'</_NpxCmd>
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
pr-comment: Run #122
🎉 All tests passed!Github Test Reporter by CTRF 💚 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.