Skip to content
This repository was archived by the owner on Apr 1, 2026. It is now read-only.

feat: add 'timeout' arg to 'Table.mutate_rows' - #157

Merged
tseaver merged 4 commits into
masterfrom
7-fix-mutation_timeout-default
Nov 12, 2020
Merged

feat: add 'timeout' arg to 'Table.mutate_rows'#157
tseaver merged 4 commits into
masterfrom
7-fix-mutation_timeout-default

Conversation

@tseaver

@tseaver tseaver commented Oct 23, 2020

Copy link
Copy Markdown
Contributor

Also, refactor implementation to avoid scribbling on the internals of the data client.

Closes #7

@tseaver
tseaver requested review from a team and crwilcox October 23, 2020 20:34
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 23, 2020
@tseaver
tseaver requested a review from kolea2 October 26, 2020 17:50
@product-auto-label product-auto-label Bot added the api: bigtable Issues related to the googleapis/python-bigtable API. label Nov 5, 2020
@crwilcox

Copy link
Copy Markdown
Contributor

seems fine enough. @kolea2 is working on incorporating the new generator, wondering how these are going to merge.

@kolea2 kolea2 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@tseaver
tseaver merged commit 6d597a1 into master Nov 12, 2020
@tseaver
tseaver deleted the 7-fix-mutation_timeout-default branch November 12, 2020 20:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigtable Issues related to the googleapis/python-bigtable API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BigTable: 'Table.mutate_rows' deadline exceeded for large mutations

3 participants