The Wayback Machine - https://web.archive.org/web/20200714072437/https://github.com/vector-im/riot-web/issues/8829
Skip to content

/ riot-web

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can we hide the algo used when turning on encryption #8829

Closed
AmandineLP opened this issue Feb 20, 2019 · 4 comments
Closed

Can we hide the algo used when turning on encryption #8829

AmandineLP opened this issue Feb 20, 2019 · 4 comments
Assignees
@jryans
Labels
bug minor p1 phase:1 story:36 type:e2e ui/ux
Projects
Workflow

Comments

@AmandineLP
Copy link
Contributor

@AmandineLP AmandineLP commented Feb 20, 2019

at least on /app as 'Amandine turned on end-to-end encryption (algorithm m.megolm.v1.aes-sha2)' is ugly as hell
@lampholder
Copy link
Member

@lampholder lampholder commented Mar 14, 2019

Yeah, this is certainly in @nadonomy's crosshairs for dejargoning the app
@aaronraimist aaronraimist mentioned this issue Jan 7, 2020
Closed
@turt2live turt2live added this to In Progress in Workflow via automation Jan 7, 2020
@turt2live turt2live moved this from In Progress to In Review in Workflow Jan 7, 2020
@jryans jryans added the story:36 label Jan 24, 2020
@manuroe manuroe mentioned this issue Jan 24, 2020
Closed
@manuroe
Copy link
Member

@manuroe manuroe commented Jan 24, 2020

Kamino cloned this issue to vector-im/riot-ios
@manuroe manuroe mentioned this issue Jan 24, 2020
Closed
@manuroe
Copy link
Member

@manuroe manuroe commented Jan 24, 2020

Kamino cloned this issue to vector-im/riotX-android
@jryans
Copy link
Member

@jryans jryans commented Jan 24, 2020

While chatting more with @ara4n, he would like to have some kind of handling of unknown algorithms at the same time as the propose hiding here. I think he came up with a decent approach:

  • When the algorithm is the one we expect (m.megolm.v1.aes-sha2), hide the algorithm as in this existing PR: %(senderName)s turned on end-to-end encryption.
  • For anything else, show the algorithm as unrecognised: %(senderName)s turned on end-to-end encryption (unrecognised algorithm %(algorithm)s).
@jryans jryans self-assigned this Jan 24, 2020
@jryans jryans removed the Community PR label Jan 24, 2020
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Jan 24, 2020
@jryans
Hide default encryption algorithm
Loading status checks…
bf0e1ef 
When the default encryption algorithm is used, we hide it to remove some jargon
from the app. For any other algorithm, we continue showing it and add
"unrecognised".

Fixes vector-im/riot-web#8829
@jryans jryans mentioned this issue Jan 24, 2020
Merged
Workflow automation moved this from In Review to In Test Jan 24, 2020
@jryans jryans added the phase:1 label Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jryans jryans

Labels
bug minor p1 phase:1 story:36 type:e2e ui/ux
Projects
Workflow
In Test
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Hide default encryption algorithm
Hide algorithm from the message about turning on encryption
5 participants
@jryans @turt2live @lampholder @manuroe @AmandineLP
You can’t perform that action at this time.