The Wayback Machine - https://web.archive.org/web/20200714071329/https://github.com/vector-im/riot-web/issues/13212
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resetting cross-signing/SSSS doesn't reset SSSS password #13212

Closed
dbkr opened this issue Apr 16, 2020 · 5 comments
Closed

Resetting cross-signing/SSSS doesn't reset SSSS password #13212

dbkr opened this issue Apr 16, 2020 · 5 comments

Comments

@dbkr
Copy link
Member

@dbkr dbkr commented Apr 16, 2020 •

It asks for the SSSS password after prompting you for a new one, but then appears to store the new cross-signing secrets with the old SSSS key, so your password stays the same.

@jryans
Copy link
Member

@jryans jryans commented Apr 16, 2020

Flagging as blocker, we definitely want a reset button that works.

@fladd
Copy link

@fladd fladd commented Apr 16, 2020 •

More importantly, the old recovery passphrase and key are still valid after the resetting procedure!

@dbkr dbkr added this to In Progress in Workflow Apr 16, 2020
@dbkr dbkr changed the title Resetting cross-signing/SSSS asks for old SSSS passphrase Resetting cross-signing/SSSS doesn't reset SSSS password Apr 16, 2020
@dbkr
Copy link
Member Author

@dbkr dbkr commented Apr 16, 2020

Updated the title & description to reflect this

@dbkr
Copy link
Member Author

@dbkr dbkr commented Apr 16, 2020

Looks like this regressed in matrix-org/matrix-js-sdk#1311

dbkr added a commit to matrix-org/matrix-js-sdk that referenced this issue Apr 16, 2020
We re-used the old SSSS key even when resetting, meaning we prompted
the user to create a new passphrase but then ignored it and kept using
the old one.

Fixes vector-im/riot-web#13212
@dbkr dbkr moved this from In Progress to In Review in Workflow Apr 16, 2020
Workflow automation moved this from In Review to In Test Apr 16, 2020
dbkr added a commit to matrix-org/matrix-js-sdk that referenced this issue Apr 16, 2020
We re-used the old SSSS key even when resetting, meaning we prompted
the user to create a new passphrase but then ignored it and kept using
the old one.

Fixes vector-im/riot-web#13212
@jryans jryans moved this from In Test to In RC in Workflow Apr 17, 2020
@non-Jedi
Copy link

@non-Jedi non-Jedi commented Apr 17, 2020 •

Is key reset expected to work on Riot Android 0.9.10 and RiotX 0.18.1? After resetting it's showing a different set of devices as verified on Riot Android and RiotX than riot-web. Can file bug/send rageshake if necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked pull requests

Successfully merging a pull request may close this issue.

4 participants
You can’t perform that action at this time.