The Wayback Machine - https://web.archive.org/web/20200714070844/https://github.com/vector-im/riot-web/issues/13157
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Verify this session' toast is shown after skipping complete security when I am logged out of all other devices #13157

Open
bwindels opened this issue Apr 14, 2020 · 2 comments

Comments

@bwindels
Copy link
Member

@bwindels bwindels commented Apr 14, 2020 •

So there is no other device to verify with. I would have expected to see a setup encryption toast rather.

@bwindels
Copy link
Member Author

@bwindels bwindels commented Apr 14, 2020 •

Repro steps would be:

  • delete all other sessions for a given user
  • logout
  • log back in, skipping complete security
  • refresh

Now you see a verify this session toast, while there is no other device to verify with. Might already happen before the refresh.

@bwindels
Copy link
Member Author

@bwindels bwindels commented Apr 14, 2020 •

We're just not checking if there is another device to verify with when there are already cross-signing keys uploaded for our user.

If there isn't another device to verify with, we should show the setup encryption toast and reset the cross-signing keys, probably showing a warning you'll loose all the trust you verified so far, when resetting. phase:4 seems adequate.

@bwindels bwindels changed the title seeing a 'Verify this session' toast when I am logged out of all other devices 'Verify this session' toast is shown after skipping complete security when I am logged out of all other devices Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.