The Wayback Machine - https://web.archive.org/web/20200714070336/https://github.com/vector-im/riot-web/issues/13042
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSO for cross-signing #13042

Closed
turt2live opened this issue Apr 6, 2020 · 7 comments
Closed

SSO for cross-signing #13042

turt2live opened this issue Apr 6, 2020 · 7 comments

Comments

@turt2live
Copy link
Member

@turt2live turt2live commented Apr 6, 2020

No description provided.

@turt2live
Copy link
Member Author

@turt2live turt2live commented Apr 6, 2020

@vector-im/design this will need designs for what it should look like during the bootstrap, key backup, and other related flows where a password would normally be asked.

@jryans
Copy link
Member

@jryans jryans commented Apr 14, 2020

@turt2live I guess I had assumed SSO UI auth would just "work" wherever UI auth is used, but maybe that's not what happens? Does it needed to be customised for each use site?

@turt2live
Copy link
Member Author

@turt2live turt2live commented Apr 14, 2020

It does work, but the default UI is a bit minimalistic (title and a button). Some copy at least would be good.

@nadonomy
Copy link
Member

@nadonomy nadonomy commented Apr 14, 2020

@turt2live I don't have the full context on when this would be prompted precisely in the user journey, but in general can we follow the standard we set here for contextual SSO prompts?

In this instance I'm not sure we'd need the 'after auth', so instead just:

Use Single Sign On to continue

To continue, use Single Sign On to prove your identity.
[Cancel] [Single Sign On]

The body copy could do with being more specific which I can add if you let me know exactly which screens this is prompted for between.

@jryans
Copy link
Member

@jryans jryans commented Apr 14, 2020

Since it at least works even if a bit confusing, tracking for after release.

@turt2live
Copy link
Member Author

@turt2live turt2live commented Apr 14, 2020

thanks @nadonomy - will try and get this in for release, but things aren't looking good on my side for that.

@turt2live
Copy link
Member Author

@turt2live turt2live commented May 6, 2020

@nadonomy we'd need the after-auth because of how the auth steps work. Following the other dialogs, presumably something like this is good enough?

Confirm encryption set up

Click the button below to confirm setting up encryption.


The screen shows up after this one:
image

@turt2live turt2live added this to In Progress in Workflow via automation May 6, 2020
turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue May 6, 2020
@turt2live turt2live moved this from In Progress to In Review in Workflow May 6, 2020
Workflow automation moved this from In Review to In Test May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Workflow
In Test
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants
You can’t perform that action at this time.