The Wayback Machine - https://web.archive.org/web/20200714065711/https://github.com/vector-im/riot-web/issues/12951
Skip to content

/ riot-web

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Riot silently fails with uncaught error when trying to verify other users. #12951

Closed
ara4n opened this issue Mar 31, 2020 · 5 comments
Closed

Riot silently fails with uncaught error when trying to verify other users. #12951

ara4n opened this issue Mar 31, 2020 · 5 comments
Assignees
@bwindels
Labels
bug feature:e2e-cross-signing phase:3 story:2
Projects
Workflow

Comments

@ara4n
Copy link
Member

@ara4n ara4n commented Mar 31, 2020 •
edited 

verification.js?8031:108 Uncaught (in promise) MatrixEvent {event: {…}, sender: null, target: null, status: null, error: null, …}event: type: "m.key.verification.cancel"content: code: "m.unknown_method"reason: "Unknown method"__proto__: Object__proto__: Objectsender: nulltarget: nullstatus: nullerror: nullforwardLooking: true_pushActions: null_replacingEvent: null_localRedactionEvent: null_isCancelled: false_clearEvent: {}_senderCurve25519Key: null_claimedEd25519Key: null_forwardingCurve25519KeyChain: []_decryptionPromise: null_retryDecryption: falseverificationRequest: null__proto__: EventEmitter
legacyVerifyUser @ verification.js?8031:108
async function (async)
legacyVerifyUser @ verification.js?8031:98
onClick @ UserInfo.js?ba98:1314
ba @ react-dom.production.min.js?ca5d:14
ja @ react-dom.production.min.js?ca5d:14
ka @ react-dom.production.min.js?ca5d:14
oa @ react-dom.production.min.js?ca5d:15
lc @ react-dom.production.min.js?ca5d:52
jc @ react-dom.production.min.js?ca5d:51
mc @ react-dom.production.min.js?ca5d:52
sc @ react-dom.production.min.js?ca5d:56
cb @ react-dom.production.min.js?ca5d:287
gb @ react-dom.production.min.js?ca5d:23
Rc @ react-dom.production.min.js?ca5d:70
id @ react-dom.production.min.js?ca5d:69
exports.unstable_runWithPriority @ scheduler.production.min.js?fb07:19
cg @ react-dom.production.min.js?ca5d:122
ab @ react-dom.production.min.js?ca5d:287
gd @ react-dom.production.min.js?ca5d:68
@ara4n ara4n added the bug label Mar 31, 2020
@ara4n
Copy link
Member Author

@ara4n ara4n commented Mar 31, 2020

prolly entangled with #12950

Verify button just silently fails.
@ara4n ara4n changed the title Riot nightly errors when trying to verify Riot silently fails with uncaught error when trying to verify other users. Mar 31, 2020
@ara4n
Copy link
Member Author

@ara4n ara4n commented Mar 31, 2020

this happens on both develop (FF) and Nightly atm.

I'm trying to verify my arasphere account from the MemberInfo in a (non-e2e) DM on my matrix.org acct.
@ara4n
Copy link
Member Author

@ara4n ara4n commented Mar 31, 2020

This looks to be failing because:

  • matrix.org thinks that @matthew:arasphere.net has no cross-signing keys. but it does.
  • it tries to do legacyVerifyUser, which fails
  • ...perhaps because the DM it tries to verify using has got unexpected cancellation events in it, due to #12950
@ara4n
Copy link
Member Author

@ara4n ara4n commented Apr 1, 2020 •
edited

The fact that legacyVerifyUser fails looks to just be legacy verification not having kept up with the latest API changes. I think something like this should fix it (untested):

diff --git a/src/verification.js b/src/verification.js
index 223134647..6a9874969 100644
--- a/src/verification.js
+++ b/src/verification.js
@@ -99,7 +99,9 @@ export async function legacyVerifyUser(user) {
         return;
     }
     const cli = MatrixClientPeg.get();
-    const verificationRequestPromise = cli.beginKeyVerification(user.userId);
+    const verificationRequestPromise = cli.beginKeyVerification(
+        verificationMethods.SAS, user.userId, undefined,
+    );
     dis.dispatch({
         action: "set_right_panel_phase",
         phase: RIGHT_PANEL_PHASES.EncryptionPanel,
@ara4n
Copy link
Member Author

@ara4n ara4n commented Apr 1, 2020

The fact that the XSKs have gone missing might be because arasphere was running a somewhat old synapse when that account set up XSK (Synapse/1.11.0)?
@bwindels bwindels mentioned this issue Apr 1, 2020
Merged
@bwindels bwindels added this to In Review in Workflow Apr 1, 2020
@bwindels bwindels self-assigned this Apr 1, 2020
Workflow automation moved this from In Review to In Test Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bwindels bwindels

Labels
bug feature:e2e-cross-signing phase:3 story:2
Projects
Workflow
In Test
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Fix: legacy verify user throwing error
3 participants
@bwindels @jryans @ara4n
You can’t perform that action at this time.