Riot/Nightly spontaneously cancelled cross-user verification from Riot 1.5.14 #12950

ara4n · 2020-03-31T13:05:17Z

@matthew:arasphere.net on Riot 1.5.14 tried to verify @matthew:matrix.org on Nightly, and got cancelled. The verif never appeared as a toast on Nightly.

The first event was:

{
  "content": {
    "body": "@matthew:arasphere.net is requesting to verify your key, but your client does not support in-chat key verification.  You will need to use legacy key verification to verify keys.",
    "from_device": "DKAZBAEEPK",
    "methods": [
      "m.sas.v1",
      "m.qr_code.show.v1",
      "m.reciprocate.v1"
    ],
    "msgtype": "m.key.verification.request",
    "to": "@matthew:matrix.org"
  },
  "event_id": "$15856596317WcHyY:arasphere.net",
  "origin_server_ts": 1585659631882,
  "sender": "@matthew:arasphere.net",
  "type": "m.room.message",
  "unsigned": {
    "age": 9138
  },
  "room_id": "!PcWroKvERfdTcjBJCK:matrix.org"
}

bwindels · 2020-03-31T13:28:58Z

The client for @matthew:matrix.org (the receiver) seems to get confused about the .request event after changing the phase:

2020-03-31T13:00:41.164Z I Verification request $15856596317WcHyY:arasphere.net: m.key.verification.request event with id:$15856596317WcHyY:arasphere.net, content:{"body":"@matthew:arasphere.net is requesting to verify your key, but your client does not support in-chat key verification.  You will need to use legacy key verification to verify keys.","from_device":"DKAZBAEEPK","methods":["m.sas.v1","m.qr_code.show.v1","m.reciprocate.v1"],"msgtype":"m.key.verification.request","to":"@matthew:matrix.org"} deviceId:undefined, sender:@matthew:arasphere.net, isSentByUs:false, isLiveEvent:true, isRemoteEcho:false, phase:1=>2, observeOnly:false=>false
2020-03-31T13:00:41.165Z I Got sound default for !PcWroKvERfdTcjBJCK:matrix.org
2020-03-31T13:00:41.180Z W Cancelling, unexpected m.key.verification.request verification event from @matthew:arasphere.net
2020-03-31T13:00:41.181Z I sendEvent of type m.key.verification.cancel in !PcWroKvERfdTcjBJCK:matrix.org with txnId m1585659641181.220

bwindels · 2020-03-31T13:35:54Z

It looks like we're processing the same .request event twice for some reason ... perhaps a race with decrypting the event?

bwindels · 2020-03-31T13:36:27Z

Will have a further look after finishing the QR stuff.

ara4n added the bug label Mar 31, 2020

ara4n changed the title ~~Verification got spontaneously cancelled.~~ Riot/Nightly spontaneously cancelled cross-user verification from Riot 1.5.14 Mar 31, 2020

jryans added cross-signing-sprint phase:3 story:2 labels Mar 31, 2020

ara4n mentioned this issue Mar 31, 2020

Riot silently fails with uncaught error when trying to verify other users. #12951

Closed

bwindels self-assigned this Mar 31, 2020

bwindels added this to In Progress in Workflow Apr 1, 2020

bwindels mentioned this issue Apr 1, 2020

Fix: spontanous verification request cancellation under some circumstances matrix-org/matrix-js-sdk#1295

Merged

bwindels moved this from In Progress to In Review in Workflow Apr 1, 2020

bwindels closed this in matrix-org/matrix-js-sdk#1295 Apr 1, 2020

Workflow automation moved this from In Review to In Test Apr 1, 2020

jryans added the feature:e2e-cross-signing label Apr 21, 2020

Jun	JUL	Aug
	14
2019	2020	2021

vector-im / riot-web

Riot/Nightly spontaneously cancelled cross-user verification from Riot 1.5.14 #12950

Riot/Nightly spontaneously cancelled cross-user verification from Riot 1.5.14 #12950

ara4n commented Mar 31, 2020

bwindels commented Mar 31, 2020 •

edited

bwindels commented Mar 31, 2020

bwindels commented Mar 31, 2020

vector-im / riot-web

Sponsor vector-im/riot-web

Join GitHub today

Riot/Nightly spontaneously cancelled cross-user verification from Riot 1.5.14 #12950

Riot/Nightly spontaneously cancelled cross-user verification from Riot 1.5.14 #12950

Comments

ara4n commented Mar 31, 2020

bwindels commented Mar 31, 2020 • edited

bwindels commented Mar 31, 2020

bwindels commented Mar 31, 2020

bwindels commented Mar 31, 2020 •

edited