The Wayback Machine - https://web.archive.org/web/20200714065218/https://github.com/vector-im/riot-web/issues/12856
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Unverified session" toast is still confusingly named. #12856

Closed
ara4n opened this issue Mar 24, 2020 · 3 comments
Closed

"Unverified session" toast is still confusingly named. #12856

ara4n opened this issue Mar 24, 2020 · 3 comments
Assignees
Projects

Comments

@ara4n
Copy link
Member

@ara4n ara4n commented Mar 24, 2020

It's very unclear what "unverified session" means. Specifically, it's unclear whether it's talking about your session or someone else's.

RiotX is much better, calling it "New sign in", which is much less ambiguous.

@ara4n ara4n added the bug label Mar 24, 2020
@ara4n ara4n changed the title "Unverified session" toast is still confusing. "Unverified session" toast is still confusingly named. Mar 24, 2020
@bwindels
Copy link
Member

@bwindels bwindels commented Mar 25, 2020 •

We discussed this in the cross-signing catchup last week, and decided against using "new" everywhere because these might have been log-ins created before you opened riot. Nad will review copy, but for now, we'd use "unknown" for both log-ins created during your riot session, and log-ins created before you opened riot. In a later phase, we'd distinguish.

@ara4n
Copy link
Member Author

@ara4n ara4n commented Mar 25, 2020

"Unverified login" might be enough or 'Unverified account login", given it's clear contextually that the login will be yours.

@nadonomy
Copy link
Member

@nadonomy nadonomy commented Mar 25, 2020

I've updated the copy in Figma to "Unknown login. Was this you?". In context it's the least ambiguous and seems to correct the right sense of urgency.

@nadonomy nadonomy removed the needs-design label Mar 25, 2020
@bwindels bwindels self-assigned this Mar 26, 2020
@bwindels bwindels removed the blocked label Mar 26, 2020
@bwindels bwindels added this to In Progress in Workflow Mar 26, 2020
@bwindels bwindels moved this from In Progress to In Review in Workflow Mar 26, 2020
Workflow automation moved this from In Review to In Test Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Workflow
In Test
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants
You can’t perform that action at this time.