The Wayback Machine - https://web.archive.org/web/20200714065153/https://github.com/vector-im/riot-web/issues/12808
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resetting cross-signing identity makes a user go to black instead of red #12808

Closed
jryans opened this issue Mar 20, 2020 · 2 comments
Closed

Resetting cross-signing identity makes a user go to black instead of red #12808

jryans opened this issue Mar 20, 2020 · 2 comments

Comments

@jryans
Copy link
Member

@jryans jryans commented Mar 20, 2020

When someone resets their cross-signing identity, we should detect that's the case and mark them with a red shield.

At the moment though, we're only showing a black shield, as if we never verified.

@jryans
Copy link
Member Author

@jryans jryans commented Mar 24, 2020

Checking with product on whether it's okay to rely on device local trust for this.

@jryans
Copy link
Member Author

@jryans jryans commented Mar 26, 2020

Sounds like using device local info is indeed okay.

jryans added a commit to matrix-org/matrix-js-sdk that referenced this issue Mar 30, 2020
This tracks whether we have ever cross-signing verified a user before (at least
as far as the current device has ever observed). This info helps to present an
alert in case the user subsequently becomes unverified.

Part of vector-im/riot-web#12808
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Mar 30, 2020
For any users that we previously verified but that are not unverified, we will
now mark them and rooms they are in with a red shield.

Fixes vector-im/riot-web#12808
@jryans jryans moved this from In Progress to In Review in Workflow Mar 30, 2020
Workflow automation moved this from In Review to In Test Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Workflow
In Test
Linked pull requests

Successfully merging a pull request may close this issue.

1 participant
You can’t perform that action at this time.