The Wayback Machine - https://web.archive.org/web/20200714065126/https://github.com/vector-im/riot-web/issues/12763
Skip to content

/ riot-web

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

During legacy verification, riot says have no verification methods in common with another riot-web session #12763

Closed
bwindels opened this issue Mar 17, 2020 · 2 comments
Closed

During legacy verification, riot says have no verification methods in common with another riot-web session #12763

bwindels opened this issue Mar 17, 2020 · 2 comments
Assignees
@bwindels
Labels
phase:3 story:2
Projects
Workflow

Comments

@bwindels
Copy link
Member

@bwindels bwindels commented Mar 17, 2020 •
edited

image

The request is still sent though and I can accept it on the other side, upon which the screen goes to SAS on the requesting side as well. This only happens for legacy verification (clicking an untrusted device in the member info and clicking "manually verify" in the dialog).
@bwindels bwindels changed the title riot says have no verification methods in common with another riot-web session During legacy verification, riot says have no verification methods in common with another riot-web session Mar 17, 2020
@bwindels
Copy link
Member Author

@bwindels bwindels commented Mar 20, 2020

Manu implies this also happens between riot-web and riot-ios
@bwindels bwindels added phase:3 and removed phase:4 labels Mar 20, 2020
@bwindels bwindels self-assigned this Mar 20, 2020
@bwindels bwindels added this to In Progress in Workflow Mar 20, 2020
@bwindels
Copy link
Member Author

@bwindels bwindels commented Mar 20, 2020

This regressed in matrix-org/matrix-react-sdk#4202
This was referenced Mar 20, 2020
Merged
Merged
@bwindels bwindels moved this from In Progress to In Review in Workflow Mar 20, 2020
Workflow automation moved this from In Review to In Test Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bwindels bwindels

Labels
phase:3 story:2
Projects
Workflow
In RC
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Fix: assume the requested method is supported by other party with to_device
Fix: assume SAS is supported when starting request with .start
1 participant
@bwindels
You can’t perform that action at this time.