The Wayback Machine - https://web.archive.org/web/20200714064802/https://github.com/vector-im/riot-web/issues/12693
Skip to content

/ riot-web

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force `is_verified` for key backups to bool and fix computation #12693

Closed
jryans opened this issue Mar 11, 2020 · 1 comment
Closed

Force `is_verified` for key backups to bool and fix computation #12693

jryans opened this issue Mar 11, 2020 · 1 comment
Assignees
@jryans
Labels
bug feature:e2e-cross-signing phase:3 regression release-blocker story:1
Projects
Workflow

Comments

@jryans
Copy link
Member

@jryans jryans commented Mar 11, 2020

We seem to send null in some cases for example.
@jryans jryans changed the title Force `is_verified` for key backups to bool Force `is_verified` for key backups to bool and fix computation Mar 12, 2020
@jryans
Copy link
Member Author

@jryans jryans commented Mar 12, 2020 •
edited

It appears we're also not checking the device trust correctly either... 😰

Regressed by #12599
@jryans jryans self-assigned this Mar 12, 2020
@jryans jryans added this to In Progress in Workflow via automation Mar 12, 2020
jryans added a commit to matrix-org/matrix-js-sdk that referenced this issue Mar 12, 2020
@jryans
Convert `trustedLocally` to a bool in all cases
e5ec2f0 
This ensure we always have a boolean value, even when device is null.

Part of vector-im/riot-web#12693
jryans added a commit to matrix-org/matrix-js-sdk that referenced this issue Mar 12, 2020
@jryans
Check key backup trust for the right user ID
Loading status checks…
3b7def8 
This corrects the key backup trust computation so that we use the user ID for
the device we're checking inside of always using the client's main user ID,
which would always resulted in false for other people.

Fixes vector-im/riot-web#12693
@jryans jryans mentioned this issue Mar 12, 2020
Merged
@jryans jryans moved this from In Progress to In Review in Workflow Mar 12, 2020
Workflow automation moved this from In Review to In Test Mar 12, 2020
jryans added a commit to matrix-org/matrix-js-sdk that referenced this issue Mar 12, 2020
@jryans
Convert `trustedLocally` to a bool in all cases
2af0e5b 
This ensure we always have a boolean value, even when device is null.

Part of vector-im/riot-web#12693
jryans added a commit to matrix-org/matrix-js-sdk that referenced this issue Mar 12, 2020
@jryans
Check key backup trust for the right user ID
Loading status checks…
b1f02d3 
This corrects the key backup trust computation so that we use the user ID for
the device we're checking inside of always using the client's main user ID,
which would always resulted in false for other people.

Fixes vector-im/riot-web#12693
@jryans jryans moved this from In Test to In RC in Workflow Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jryans jryans

Labels
bug feature:e2e-cross-signing phase:3 regression release-blocker story:1
Projects
Workflow
In Test
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Force `is_verified` for key backups to bool and fix computation
1 participant
@jryans
You can’t perform that action at this time.