The Wayback Machine - https://web.archive.org/web/20200714064638/https://github.com/vector-im/riot-web/issues/12661
Skip to content

/ riot-web

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Secret sharing should expect m.cross_signing prefix #12661

Closed
jryans opened this issue Mar 9, 2020 · 0 comments
Closed

Secret sharing should expect m.cross_signing prefix #12661

jryans opened this issue Mar 9, 2020 · 0 comments
Assignees
@jryans
Labels
feature:e2e-cross-signing phase:2 story:1
Projects
Workflow

Comments

@jryans
Copy link
Member

@jryans jryans commented Mar 9, 2020

At the moment, we're checking for m.key but we should check for m.cross_signing.
@jryans jryans self-assigned this Mar 9, 2020
@jryans jryans added this to In Progress in Workflow via automation Mar 9, 2020
jryans added a commit to matrix-org/matrix-js-sdk that referenced this issue Mar 9, 2020
@jryans
Fix secret sharing names to match spec
Loading status checks…
b5eea01 
When sharing keys, we should use `m.cross_signing` prefix.

Part of vector-im/riot-web#12661
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Mar 9, 2020
@jryans
Fix secret sharing names to match spec
Loading status checks…
47b1552 
When sharing keys, we should use `m.cross_signing` prefix.

Part of vector-im/riot-web#12661
This was referenced Mar 9, 2020
Merged
Merged
@jryans jryans moved this from In Progress to In Review in Workflow Mar 9, 2020
Workflow automation moved this from In Review to In Test Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jryans jryans

Labels
feature:e2e-cross-signing phase:2 story:1
Projects
Workflow
In Test
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Fix secret sharing names to match spec
1 participant
@jryans
You can’t perform that action at this time.