The Wayback Machine - https://web.archive.org/web/20200714102627/https://github.com/vector-im/riot-web/issues/12619
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate legacy trust to cross-signing #12619

Closed
bwindels opened this issue Mar 5, 2020 · 2 comments
Closed

Migrate legacy trust to cross-signing #12619

bwindels opened this issue Mar 5, 2020 · 2 comments
Labels

Comments

@bwindels
Copy link
Member

@bwindels bwindels commented Mar 5, 2020 •

Ensure that If I bootstrap SSSS after legacy verifying, my legacy verifications should be migrated to signing those users.

The JS-SDK already has some code for this, but the react-sdk isn't providing the shouldUpgradeDeviceVerifications callback yet. We're relying there on the device having signed the master key, which we currently only do during bootstrapping. We discussed all devices signing the master key with their device key once they start participating in cross-signing, but deemed it not worth it. So this means that you will only be able to migrate legacy trust if you had legacy verified the device on which the other user has bootstrapped cross-signing.

@bwindels
Copy link
Member Author

@bwindels bwindels commented Mar 5, 2020

There's also a .. chick and egg problem here I think ... if I only attempt migrating once I enable cross-signing, and I am the first one of my contacts to do so, I won't be able to migrate as nobody has uploaded cross-signing keys yet. So apart from attempting it automatically when enabling cross-signing, we might also want the user to explicitly attempt migration by e.g. a button in the security settings.

@jryans
Copy link
Member

@jryans jryans commented May 20, 2020

The time window for this has mostly passed now that cross-signing has released.

@jryans jryans closed this May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.