just tested, and the request gets sent correctly, and seems to be received (as I get the line below in the logs of the target device) but for some reason no toast is shown.

Verification request xSgckKz7STKVQwU4bPJlbeegjsaJ8cX7: m.key.verification.request event with id:undefined, content:{"methods":["m.sas.v1","m.qr_code.show.v1","m.reciprocate.v1"],"transaction_id":"xSgckKz7STKVQwU4bPJlbeegjsaJ8cX7","from_device":"JPSZBGMWUS","timestamp":1583339691414} deviceId:JPSZBGMWUS, sender:@bruno-cs3:localhost, isSentByUs:false, isLiveEvent:true, isRemoteEcho:false, phase:1=>2, observeOnly:false=>false

Created #12621 for UX confusion mentioned here, and lack of comparing public keys. This ticket is just about the device verification not working.

Very weird, I can't repro this anymore. Have tried locally and on /develop and I always get a toast now...

@jryans can you still repro this? I've tried with multiple accounts on /develop and local dev after having pulled, can't repro at all anymore.

test with an account with xsigning turned off (no uploaded keys, no flag), dave hit this and rageshaked

Yes, I am still able to reproduce when the target user does not have keys or the flag enabled.

The request appears when the target user enables the flag even without uploading keys. I did notice in MatrixChat that we only bind the crypto.verification.request listener when cross-signing is enabled, but making that unconditional did not seem to be enough for the toast to appear, so there must be another lurking check as well...

With the xsign flag off on the receiving side, I indeed don't see a toast