The Wayback Machine - https://web.archive.org/web/20200714063945/https://github.com/vector-im/riot-web/issues/12484
Skip to content

/ riot-web

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only include current user status in shield rules for topic rooms (not DM rooms) #12484

Closed
jryans opened this issue Feb 24, 2020 · 0 comments
Closed

Only include current user status in shield rules for topic rooms (not DM rooms) #12484

jryans opened this issue Feb 24, 2020 · 0 comments
Assignees
@foldleft
Labels
feature:e2e-cross-signing phase:3 story:3
Projects
Workflow

Comments

@jryans
Copy link
Member

@jryans jryans commented Feb 24, 2020

We've made further refinement to the shield decoration logic:

The set of “all users” depends on the type of room:

  • For regular / topic rooms, all users including yourself, are considered when decorating a room
  • For 1:1 and group DM rooms, all other users (i.e. excluding yourself) are considered when decorating a room
@jryans jryans changed the title Only include user status in shield rules for topic rooms (not DM rooms) Only include current user status in shield rules for topic rooms (not DM rooms) Feb 24, 2020
@foldleft foldleft self-assigned this Mar 27, 2020
@foldleft foldleft added this to In Progress in Workflow via automation Mar 27, 2020
@foldleft foldleft mentioned this issue Mar 27, 2020
Merged
@foldleft foldleft moved this from In Progress to In Review in Workflow Mar 30, 2020
Workflow automation moved this from In Review to In Test Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@foldleft foldleft

Labels
feature:e2e-cross-signing phase:3 story:3
Projects
Workflow
In Test
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Refactor shield display logic; changed rules for DMs
2 participants
@jryans @foldleft
You can’t perform that action at this time.