The Wayback Machine - https://web.archive.org/web/20200714063924/https://github.com/vector-im/riot-web/issues/12481
Skip to content

/ riot-web

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SAS verification leaks DOM trees #12481

Closed
ara4n opened this issue Feb 24, 2020 · 1 comment
Closed

SAS verification leaks DOM trees #12481

ara4n opened this issue Feb 24, 2020 · 1 comment
Assignees
@bwindels
Labels
feature:e2e-cross-signing phase:2 story:2
Projects
Workflow

Comments

@ara4n
Copy link
Member

@ara4n ara4n commented Feb 24, 2020

No description provided.

@ara4n
Copy link
Member Author

@ara4n ara4n commented Feb 24, 2020 •
edited

After #12478, I did a heap snapshot (for the sake of paranoia, after the fun of #12417. I had several new DOM trees leaked, which look to have been leaked out of the SAS verification code.

Screenshot 2020-02-24 at 10 17 58
@bwindels bwindels self-assigned this Feb 24, 2020
@bwindels bwindels added this to In Progress in Workflow Feb 24, 2020
@bwindels bwindels mentioned this issue Feb 24, 2020
Merged
@bwindels bwindels moved this from In Progress to In Review in Workflow Feb 24, 2020
Workflow automation moved this from In Review to In Test Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bwindels bwindels

Labels
feature:e2e-cross-signing phase:2 story:2
Projects
Workflow
In RC
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Don't leak if show_sas never comes (or already came)
3 participants
@bwindels @jryans @ara4n
You can’t perform that action at this time.