The Wayback Machine - https://web.archive.org/web/20200714063630/https://github.com/vector-im/riot-web/issues/12426
Skip to content

/ riot-web

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Completing security" infinispinnered on a fresh login #12426

Closed
ara4n opened this issue Feb 20, 2020 · 9 comments
Closed

"Completing security" infinispinnered on a fresh login #12426

ara4n opened this issue Feb 20, 2020 · 9 comments
Assignees
@jryans
Labels
bug feature:e2e-cross-signing p1 phase:2 story:1
Projects
Workflow

Comments

@ara4n
Copy link
Member

@ara4n ara4n commented Feb 20, 2020

Just logged into my main account on a local develop. It prompted me quite early on for my SSSS passphrase in order to login. Initialsync then completed in the bg... but it sat there infinispinnering at me :/

Screenshot 2020-02-20 at 02 08 41

matrix-org/riot-web-rageshakes#2284
@ara4n ara4n added the bug label Feb 20, 2020
@ara4n
Copy link
Member Author

@ara4n ara4n commented Feb 20, 2020

also, why are there two indexedb workers?! :/
@ara4n
Copy link
Member Author

@ara4n ara4n commented Feb 20, 2020

i eventually got bored and hit refresh and got into the app. however, my megolm keys hadn't loaded from online backup... and despite the thing claiming that it's participating in online backup, I am failing to see a way to kick it to re-download them.
@ara4n
Copy link
Member Author

@ara4n ara4n commented Mar 6, 2020

i'm designating this as 'fire' given it's impacting every log in, and richvdh got bitten by it earlier.
@ara4n
Copy link
Member Author

@ara4n ara4n commented Mar 6, 2020 •
edited

context, I've been staring at this for about 15 minutes now:

Screenshot 2020-03-06 at 23 49 36

and why are there 4 indexeddb workers?!
@jryans
Copy link
Member

@jryans jryans commented Mar 7, 2020

and why are there 4 indexeddb workers?!

We leak a worker whenever the client is stopped, filed #12642.
@jryans jryans self-assigned this Mar 9, 2020
@jryans jryans added this to In Progress in Workflow via automation Mar 9, 2020
@jryans
Copy link
Member

@jryans jryans commented Mar 9, 2020 •
edited

i'm designating this as 'fire' given it's impacting every log in, and richvdh got bitten by it earlier.

I don't think this technically meets our definition of fire, since it's not a regression or high visibility issue we'd do an off-cycle release for, so I'll clear the label... It only appears to happen for larger accounts with cross-signing, as best as I can tell, which is only enabled by default on develop.

In any case, we're looking at it. 😄
@jryans jryans removed the 🔥 Fire 🔥 label Mar 9, 2020
@jryans
Copy link
Member

@jryans jryans commented Mar 9, 2020 •
edited

For @ara4n's logs, unfortunately they seem to be truncated and the initial phase of login is not captured, so it's hard to say what happened there.

From @richvdh's logs, the main slowdown appears to key signature upload, which suggests this is a version of #12223, so I'll focus on that one first and then ask for retesting here.
@jryans
Copy link
Member

@jryans jryans commented Mar 10, 2020

Develop now has a fix for the related issue #12223. @ara4n and @richvdh, could you please retest?
@jryans
Copy link
Member

@jryans jryans commented Mar 14, 2020

Ah actually, I've spotted another issue that's probably important here: we're currently awaiting a full key backup restore during login... 😬
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Mar 16, 2020
@jryans
Restore key backup in background after complete security
Loading status checks…
c245c69 
We were blocking the complete security flow on waiting for a key backup restore
to complete, which could take multiple minutes with no visible progress.

Fixes vector-im/riot-web#12426
@jryans jryans mentioned this issue Mar 16, 2020
Merged
@jryans jryans moved this from In Progress to In Review in Workflow Mar 16, 2020
Workflow automation moved this from In Review to In Test Mar 17, 2020
@jryans jryans mentioned this issue Apr 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jryans jryans

Labels
bug feature:e2e-cross-signing p1 phase:2 story:1
Projects
Workflow
In RC
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Restore key backup in background after complete security
2 participants
@jryans @ara4n
You can’t perform that action at this time.