The Wayback Machine - https://web.archive.org/web/20200714063503/https://github.com/vector-im/riot-web/issues/12375
Skip to content

/ riot-web

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify QR codes with binary packing #12375

Closed
jryans opened this issue Feb 14, 2020 · 0 comments
Closed

Simplify QR codes with binary packing #12375

jryans opened this issue Feb 14, 2020 · 0 comments
Assignees
@turt2live
Labels
feature:e2e-cross-signing phase:3 story:2
Projects
Workflow

Comments

@jryans
Copy link
Member

@jryans jryans commented Feb 14, 2020

The QR code MSC has been updated to pack the data in more efficient binary format to reduce QR code size.

We should update web to match.
@turt2live turt2live self-assigned this Feb 19, 2020
@turt2live turt2live added this to In Progress in Workflow via automation Feb 19, 2020
turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue Feb 20, 2020
@turt2live
Use binary packing for verification QR codes
Loading status checks…
45963ad 
Fixes vector-im/riot-web#12257
Fixes vector-im/riot-web#12375

We do not remove the existing QR code library in this commit because it is still used elsewhere (like the share dialog). 

This should be as accurate as possible to what [MSC1543](matrix-org/matrix-doc#1544) asks for.
@turt2live turt2live mentioned this issue Feb 20, 2020
Merged
@turt2live turt2live moved this from In Progress to In Review in Workflow Feb 20, 2020
Workflow automation moved this from In Review to In Test Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turt2live turt2live

Labels
feature:e2e-cross-signing phase:3 story:2
Projects
Workflow
In RC
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Use binary packing for verification QR codes
2 participants
@jryans @turt2live
You can’t perform that action at this time.