The Wayback Machine - https://web.archive.org/web/20200714103503/https://github.com/vector-im/riot-web/issues/12215
Skip to content

/ riot-web

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verification in DM: 3rd user sends .cancel after receiver sends .ready #12215

Closed
bwindels opened this issue Feb 3, 2020 · 1 comment
Closed

Verification in DM: 3rd user sends .cancel after receiver sends .ready #12215

bwindels opened this issue Feb 3, 2020 · 1 comment
Assignees
@bwindels
Labels
bug defect feature:e2e-cross-signing phase:2 story:2
Projects
Workflow

Comments

@bwindels
Copy link
Member

@bwindels bwindels commented Feb 3, 2020

While reproducing #12211, I noticed that the 3rd user not part of the request sends a .cancel (that is rightfully ignored by the other parties) saying it didn't expect a .ready event in phase 1 (unsent)
@bwindels bwindels mentioned this issue Feb 4, 2020
Closed
@bwindels bwindels self-assigned this Feb 27, 2020
@bwindels bwindels added this to In Progress in Workflow Feb 27, 2020
@bwindels
Copy link
Member Author

@bwindels bwindels commented Feb 27, 2020

Can still repro, gets sent after the .ready event:

{
  "room_id": "!oJBqmIFXnbHJzrlOdP:localhost",
  "type": "m.key.verification.cancel",
  "content": {
    "code": "m.unexpected_message",
    "reason": "Unexpected m.key.verification.ready event in phase 1"
  }
}
@bwindels bwindels mentioned this issue Feb 27, 2020
Merged
@bwindels bwindels moved this from In Progress to In Review in Workflow Feb 27, 2020
Workflow automation moved this from In Review to In Test Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bwindels bwindels

Labels
bug defect feature:e2e-cross-signing phase:2 story:2
Projects
Workflow
In Test
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Don't cancel as 3rd party in verification request
2 participants
@bwindels @jryans
You can’t perform that action at this time.