The Wayback Machine - https://web.archive.org/web/20200714062129/https://github.com/vector-im/riot-web/issues/12106
Skip to content

/ riot-web

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rendering issue in the sign-in verification flow #12106

Closed
foldleft opened this issue Jan 28, 2020 · 2 comments
Closed

rendering issue in the sign-in verification flow #12106

foldleft opened this issue Jan 28, 2020 · 2 comments
Assignees
@foldleft
Labels
bug feature:e2e-cross-signing phase:1 story:1
Projects
Workflow

Comments

@foldleft
Copy link
Contributor

@foldleft foldleft commented Jan 28, 2020 •
edited

I initiated a verification from another riot-web instance. the instance signing in rendered as per the image
Screenshot 2020-01-28 at 13 38 43
@jryans
Copy link
Member

@jryans jryans commented Jan 28, 2020

@foldleft, can you describe how you reached a verification flow at sign-in...?

Did you login, stop at complete security, then go to existing device and try to verify the new session?
@jryans jryans added the story:34 label Jan 28, 2020
@foldleft
Copy link
Contributor Author

@foldleft foldleft commented Jan 28, 2020

Sure

A: Log in with a new device and stop here (private mode, which may be germane)
Screenshot 2020-01-28 at 16 38 32

B: click review toast here
Screenshot 2020-01-28 at 16 38 35

B: click begin verifying here
Screenshot 2020-01-28 at 16 38 39

A: proceeds automatically to this screen
Screenshot 2020-01-28 at 16 38 45
@bwindels bwindels mentioned this issue Jan 28, 2020
Closed
2 of 2 tasks complete
@foldleft foldleft mentioned this issue Jan 29, 2020
Closed
@jryans jryans added this to In Review in Workflow Jan 29, 2020
@foldleft foldleft moved this from In Review to In Progress in Workflow Jan 30, 2020
@foldleft foldleft mentioned this issue Jan 30, 2020
Merged
@jryans jryans moved this from In Progress to In Review in Workflow Jan 30, 2020
Workflow automation moved this from In Review to In Test Jan 30, 2020
@jryans jryans added phase:1 story:1 and removed story:34 labels Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@foldleft foldleft

Labels
bug feature:e2e-cross-signing phase:1 story:1
Projects
Workflow
In Test
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

fix SAS dialog width
Fix a fixed-width render issue in the sign-in verification flow
2 participants
@jryans @foldleft
You can’t perform that action at this time.