The Wayback Machine - https://web.archive.org/web/20200714061849/https://github.com/vector-im/riot-web/issues/12067
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After cross-signing successfully adds device, there is still a dialog infini-spinner remaining #12067

Closed
benparsons opened this issue Jan 27, 2020 · 9 comments

Comments

@benparsons
Copy link
Member

@benparsons benparsons commented Jan 27, 2020 •

Screenshot 2020-01-27 at 11 37 11

@foldleft
Copy link
Contributor

@foldleft foldleft commented Jan 27, 2020

Thanks for the feedback!

I've been unable to repro yet. Here's the steps I tried:

  1. Solo
  • Tried logging in on https://riot.im/app as test2 on my local instance. As this user had no devices, I was prompted for a cross-signing key directly. I was unable to repro.
@turt2live
Copy link
Member

@turt2live turt2live commented Jan 27, 2020

I had this this morning too. I wrote it off as slow homeserver, but I believe Ben's should be fast enough.

@foldleft
Copy link
Contributor

@foldleft foldleft commented Jan 27, 2020

  1. With two riot-web devices, one running develop (A) and one on riot.im/app (B)
  • Login screen on B

Screenshot 2020-01-27 at 16 01 13

Screenshot 2020-01-27 at 16 01 24

* A gets a request. **At this point my options fork, and I proceed from A**

Screenshot 2020-01-27 at 16 01 33

Screenshot 2020-01-27 at 16 01 38

Screenshot 2020-01-27 at 16 01 47

* Device B gets a query about this

Screenshot 2020-01-27 at 16 01 52

* Device A's state changes

Screenshot 2020-01-27 at 16 02 05

* Device B follows through

Screenshot 2020-01-27 at 16 02 12

Screenshot 2020-01-27 at 16 02 17

* Device A supplies the SSSS key

Screenshot 2020-01-27 at 16 02 27

Screenshot 2020-01-27 at 16 02 40

* Device B is told things are good, and is prompted for the same SSSS key for backups

Screenshot 2020-01-27 at 16 02 49

Screenshot 2020-01-27 at 16 02 55

@foldleft
Copy link
Contributor

@foldleft foldleft commented Jan 27, 2020

oh! I think I just got a repro. there was a moment there where both clients were sitting in the "waiting for client to accept" state for about 10s

@turt2live
Copy link
Member

@turt2live turt2live commented Jan 27, 2020

I got it after the emoji were confirmed, as I think @benparsons did too.

@turt2live
Copy link
Member

@turt2live turt2live commented Jan 27, 2020

The spinner before is almost certainly homeserver delays.

@benparsons
Copy link
Member Author

@benparsons benparsons commented Jan 27, 2020

yeah for me the dialog I show in the screenshot was just sat there at the end of the whole process

@jryans jryans added the phase:2 label Feb 10, 2020
@foldleft
Copy link
Contributor

@foldleft foldleft commented Feb 12, 2020

can't repro due to being unable to complete the flow right now (doing a synapse/riot-web rebuild to check it's not old state) but this flow is very changed, maybe we should close this one as unreproduceable

@jryans
Copy link
Member

@jryans jryans commented Feb 12, 2020

Makes sense to me, let's track any remaining problems in fresh issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.