The Wayback Machine - https://web.archive.org/web/20200714061717/https://github.com/vector-im/riot-web/issues/12030
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should be able to view E2E info and verify users in MemberInfo, even if the room is unencrypted #12030

Closed
turt2live opened this issue Jan 24, 2020 · 6 comments

Comments

@turt2live
Copy link
Member

@turt2live turt2live commented Jan 24, 2020 •

Even if they're unencrypted

@turt2live turt2live changed the title "Should be able to verify other people from MemberInfo in DMs" "Even if they're unencrypted Should be able to verify other people from MemberInfo in DMs Jan 24, 2020
@t3chguy t3chguy added the needs-design label Feb 6, 2020
@t3chguy
Copy link
Collaborator

@t3chguy t3chguy commented Feb 6, 2020

I think the devil is in the execution details on this— I'd prefer to detail some copy & comps for these states before you start lifting code, does that work for you?

@t3chguy t3chguy self-assigned this Feb 6, 2020
@jryans jryans added the suggestion label Feb 17, 2020
@ara4n ara4n changed the title Should be able to verify other people from MemberInfo in DMs Should be able to view E2E info and verify users in MemberInfo, even if the room is unencrypted Mar 12, 2020
@ara4n
Copy link
Member

@ara4n ara4n commented Mar 12, 2020

This is constantly tripping me up. I want to see what devices a user has; i go to their MemberInfo, and look blank because i'm in an unencrypted room. I want to verify them; similarly.

@nadonomy do you agree MemberInfo should show the same whether it's in an encrypted room or not?

@nadonomy
Copy link
Member

@nadonomy nadonomy commented Mar 13, 2020

@nadonomy do you agree MemberInfo should show the same whether it's in an encrypted room or not?

Yup. I'm not sure if it's as binary as displaying the exact same thing though, will review the micro copy and figure out what other changes (if any) are needed.

@ara4n
Copy link
Member

@ara4n ara4n commented Mar 24, 2020

this continues to massively trip me up - c.f. the related mess in #12850 (comment)

@nadonomy
Copy link
Member

@nadonomy nadonomy commented Mar 25, 2020 •

Having looked at the user journey in more detail, when viewing users in unencrypted rooms, we need to vary the copy in 3 places, detailed below. We also shouldn't need to modify the current decoration logic.

@jryans @manuroe @BillCarsonFr what's the best way to track this cross-platform? Are you ok to echo the issue across respective repos?


1. Viewing profiles

E2E: Messages in this room are end-to-end encrypted.
Non E2E: Messages in this room are not end-to-end encrypted.

2. Before verifying

After clicking [Verify], before clicking [Start Verification]

E2E:

Messages in this room are end-to-end encrypted.

Your messages are secured and only you and the recipient have the unique keys to unlock them.

Non E2E:

Messages in this room are not end-to-end encrypted.

In encrypted rooms, your messages are secured and only you and the recipient have the unique keys to unlock them.

3. After verifying

E2E: Verify all users in a room to ensure it’s secure.
Non E2E: In encrypted rooms, verify all users in a room to ensure it’s secure.

@nadonomy nadonomy removed the needs-design label Mar 25, 2020
@t3chguy t3chguy assigned t3chguy and unassigned nadonomy Mar 25, 2020
@t3chguy t3chguy added this to In Progress in Workflow via automation Mar 25, 2020
@t3chguy t3chguy moved this from In Progress to In Review in Workflow Mar 25, 2020
Workflow automation moved this from In Review to In Test Mar 26, 2020
@jryans
Copy link
Member

@jryans jryans commented Mar 26, 2020

@jryans @manuroe @BillCarsonFr what's the best way to track this cross-platform? Are you ok to echo the issue across respective repos?

At the moment, our approach is each team filing issues in their repos as needed and labelling for the story. It does take some vigilance to avoid things falling in the cracks, so something to ponder for the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked pull requests

Successfully merging a pull request may close this issue.

6 participants
You can’t perform that action at this time.