Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upShould be able to view E2E info and verify users in MemberInfo, even if the room is unencrypted #12030
Comments
|
|
This is constantly tripping me up. I want to see what devices a user has; i go to their MemberInfo, and look blank because i'm in an unencrypted room. I want to verify them; similarly. @nadonomy do you agree MemberInfo should show the same whether it's in an encrypted room or not? |
Yup. I'm not sure if it's as binary as displaying the exact same thing though, will review the micro copy and figure out what other changes (if any) are needed. |
|
this continues to massively trip me up - c.f. the related mess in #12850 (comment) |
|
Having looked at the user journey in more detail, when viewing users in unencrypted rooms, we need to vary the copy in 3 places, detailed below. We also shouldn't need to modify the current decoration logic. @jryans @manuroe @BillCarsonFr what's the best way to track this cross-platform? Are you ok to echo the issue across respective repos? 1. Viewing profilesE2E: Messages in this room are end-to-end encrypted. 2. Before verifyingAfter clicking [Verify], before clicking [Start Verification] E2E:
Non E2E:
3. After verifyingE2E: Verify all users in a room to ensure it’s secure. |
At the moment, our approach is each team filing issues in their repos as needed and labelling for the story. It does take some vigilance to avoid things falling in the cracks, so something to ponder for the future. |


Even if they're unencrypted