The Wayback Machine - https://web.archive.org/web/20200714061701/https://github.com/vector-im/riot-web/issues/11993
Skip to content

/ riot-web

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

render invalid verification requests as a tile of height 0 #11993

Open
bwindels opened this issue Jan 22, 2020 · 2 comments
Open

render invalid verification requests as a tile of height 0 #11993

bwindels opened this issue Jan 22, 2020 · 2 comments
Labels
feature:e2e-cross-signing phase:4 story:2

Comments

@bwindels
Copy link
Member

@bwindels bwindels commented Jan 22, 2020

No description provided.

@bwindels
Copy link
Member Author

@bwindels bwindels commented Jan 22, 2020 •
edited

verification tiles in phase PHASE_UNSENT (through invalid prop) are now rendered as empty, but they still take up some height because of the parent components.

render the full event tile at height 0 until they become valid.
@bwindels bwindels mentioned this issue Feb 4, 2020
Closed
@jryans jryans added phase:2 story:2 and removed story:35 labels Feb 10, 2020
@jryans jryans added phase:4 and removed phase:2 labels Feb 18, 2020
@bwindels
Copy link
Member Author

@bwindels bwindels commented Feb 18, 2020

less of a problem now that we don't require .done events from both sides
@bwindels bwindels mentioned this issue May 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature:e2e-cross-signing phase:4 story:2
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@bwindels @jryans
You can’t perform that action at this time.