The original change here feels a bit misguided. We still require keyshare requests for RiotX->Web to get information about devices and such. Cross signing does help, though there are legitimate use cases where key sharing is required.

We've backed the original change out for the demo.

The key share dialog (disabled with cross-signing in matrix-org/matrix-react-sdk#3860) is only used for unverified devices. For verified devices, we send immediately and that has not changed.

It would be good to have more details on this scenario to track down what failed and what should be happening.

we were pretty tired at the time - would be worth talking it over with @BillCarsonFr to see what was going on.

For the record here, there was a bug that prevented auto key sharing with cross-signed device. Fixed by matrix-org/matrix-js-sdk#1243.

This dialog is still planned for removal when cross-signing is out of labs.