The Wayback Machine - https://web.archive.org/web/20200714061159/https://github.com/vector-im/riot-web/issues/11398
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shields artwork is wonky #11398

Closed
ara4n opened this issue Nov 15, 2019 · 2 comments
Closed

Shields artwork is wonky #11398

ara4n opened this issue Nov 15, 2019 · 2 comments

Comments

@ara4n
Copy link
Member

@ara4n ara4n commented Nov 15, 2019

We've lost the border.

It should be:

Screenshot 2019-11-15 at 20 30 37

It is:

Screenshot 2019-11-15 at 20 30 01

@bwindels
Copy link
Member

@bwindels bwindels commented Nov 19, 2019 •

Yeah, I took a compromise while trying to keep the icons styleable with css using mask-image: ... for theming. The exclamation mark was white because I put a white psuedo element behind the shield (just removed this). I guess I'll need to use two layers to the icon for every color. Just making the red themeable and keep the white hardcoded wouldn't be possible with mask-image either ...

@bwindels
Copy link
Member

@bwindels bwindels commented Nov 21, 2019

After discussing with Nad, we'll make the e2e icons non-themable, so no need for css masks.

@bwindels bwindels added this to In Progress in Workflow Nov 21, 2019
@bwindels bwindels self-assigned this Nov 21, 2019
@bwindels bwindels moved this from In Progress to In Review in Workflow Nov 21, 2019
Workflow automation moved this from In Review to In Test Nov 21, 2019
@jryans jryans added the phase:1 label Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants
You can’t perform that action at this time.