The Wayback Machine - https://web.archive.org/web/20200714061010/https://github.com/vector-im/riot-web/issues/11221
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New UI for devices section #11221

Open
dbkr opened this issue Oct 24, 2019 · 8 comments
Open

New UI for devices section #11221

dbkr opened this issue Oct 24, 2019 · 8 comments

Comments

@dbkr
Copy link
Member

@dbkr dbkr commented Oct 24, 2019

Implement new UI for the devices section in settings

  • We should base this off the union of what we get from the devices CS endpoint and the devices from e2e (currently settings has the former and you get the latter if you click on yourself in the member list of a room...)
  • No UI for this yet, but devices that appear in the CS endpoint but not in e2e (ie. they don't do e2e) should be displayed in some appropriate way.
@t3chguy
Copy link
Collaborator

@t3chguy t3chguy commented Nov 1, 2019

Accessibility is a requirement here, existing solution is not very accessible

@jryans
Copy link
Member

@jryans jryans commented Feb 12, 2020

Figma

2020-02-12 at 10 27

  • Update device info in security section of settings to match design above
  • Display device trust status
@MurzNN
Copy link
Contributor

@MurzNN MurzNN commented Apr 4, 2020

Will be good also add button "Verify" for unverified devices. Because now when user press "Later" in cross-signing toast at top-left, later he can't understand where to find interface for verify this device.

@MurzNN
Copy link
Contributor

@MurzNN MurzNN commented Apr 4, 2020

Also will be good to stay "Last seen" info always visible in list, at least last seen time, and ID + IP on tooltip.

@jryans
Copy link
Member

@jryans jryans commented May 21, 2020

Marking this temporarily as needs-design: while we do have some designs above in Figma, design would like to iterate on it a bit more over the next few days, so please check in with them to ensure latest designs are ready.

@matthijskooijman
Copy link

@matthijskooijman matthijskooijman commented Jul 6, 2020

One more suggestion: A "Sign out of all untrusted" button might also be useful to clean up old sessions (especially useful for cleaning up a lot of sessions that predate the new verification mechanisms so were never verified).

And/or maybe "Sign out inactive sessions" for signing out sessions that are no longer active (e.g. browser that has cookies deleted without logout, old mobile devices, etc.). The definition of "inactive" is probably tricky, but something like "not seen for a week" could be sufficient?

Also, the design above no longer allows bulk deleting by clicking checkboxes (and assuming that the delete will show an "are you sure" prompt, deleting a bunch of sessions might then be cumbersome). However, if a mechanism is added to remove untrusted and/or inactive sessions, then that probably covers most of the usecases for bulk deletes.

@matthijskooijman
Copy link

@matthijskooijman matthijskooijman commented Jul 6, 2020

The design above no longer shows which session is the current session, which I think is still valuable (see also related #14344 about showing the current session in the profile view).

@matthijskooijman
Copy link

@matthijskooijman matthijskooijman commented Jul 6, 2020

Sorry for the spam, just trying to connect together some issues and create a bit of overview :-)

I previously filed #14343 about the "Review where you're logged in" toast, which redirects to your own profile view, and where it is quite unclear what needs to happen there. I think that the profile view might actually be the wrong place to redirect (but I think it's currently the only place where you can start a verification of your own sessions).

If the devices section in the settings is improved per this issue, then it would make more sense for the "Review where you're logged in" toast to actually redirect to the settings rather than the profile list. I'm not authoritative on this, but maybe this can be considered when designing this interface.

One improvement that follows this is that the help text could provide some more guidance about what to actually do to "review where you're logged in". In the design above, there is already some guidance, but maybe some suggestion to remove outdated and/or untrusted sessions might be useful as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants
You can’t perform that action at this time.