The Wayback Machine - https://web.archive.org/web/20200714060908/https://github.com/vector-im/riot-ios/issues/3138
Skip to content

/ riot-ios

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix verification of user with no cross-signing #3138

Closed
manuroe opened this issue Apr 22, 2020 · 0 comments
Closed

Fix verification of user with no cross-signing #3138

manuroe opened this issue Apr 22, 2020 · 0 comments
Assignees
@manuroe
Labels
bug phase:2 story:2 story:3
Milestone
Sprint 26: Cross-...

Comments

@manuroe
Copy link
Member

@manuroe manuroe commented Apr 22, 2020 •
edited

Nothing happens when tapping in RoomMember > Verify.

We need to do the same as Riot-web. It sends to_device verification requests to [userDevice1, userDevice2, userDevice3].

Users will stay black (green is only for verified with cross-signing). The new verified device will come green.
If the user taps again on verify, we will send the exact same request to [userDevice1, userDevice2, userDevice3].

Riot-web displays:
image

image
@manuroe manuroe mentioned this issue Apr 22, 2020
Closed
@manuroe manuroe self-assigned this Apr 23, 2020
manuroe added a commit that referenced this issue Apr 23, 2020
@manuroe
Cross-signing: Allow to verify each device of users with no cross-sig…
38fd4fd 
…ning

Fix #3138
This is implemented by adding a new `UserEncryptionTrustLevel` value: `UserEncryptionTrustLevelNoCrossSigning`
@manuroe manuroe mentioned this issue Apr 23, 2020
Merged
@manuroe manuroe added the phase:2 label Apr 27, 2020
@manuroe manuroe added phase:3 and removed phase:3 labels May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@manuroe manuroe

Labels
bug phase:2 story:2 story:3
Projects
None yet
Milestone
Sprint 26: Cross-...
Linked pull requests

Successfully merging a pull request may close this issue.

Cross-signing: Allow to verify each device of users with no cross-signing
1 participant
@manuroe
You can’t perform that action at this time.