Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upCrossSigning / Update Shield Logic #2975
Open
Milestone
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment


#see vector-im/riot-web#12214
There are some cases where this doesn't happen today, e.g. if you have not verified one of your own devices, all rooms would go red (even large public rooms where you have no intention verifying users).
To make the experience more straightforward, we decided after chatting with @dbkr and @nadonomy to add the additional check that green / red states are only shown if you have verified at least one user in the room. If you haven't, the room is black.
Summary doc on shields: https://docs.google.com/document/d/1RFUN0YRrOs8QZwiblaUbs4wWR0BjA0hBJ27rKJ57Zvk/edit
Checklist for this doc:
User profiles
- [ ] None: e2e off in the roomRooms
(Added 2020-02-24) The set of “all users” depends on the type of room:
The somewhat complex parenthetical bits above are to avoid a case where you have an unverified device (since “a red user exists” includes yourself) and would have caused black rooms to go red if we didn’t add a check for other verified users.
Messages
Type of trust to check
Devices