Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upCross Signing Support #832
Merged
Conversation
Start of cross-signing impl
and restore them from the key backup. NB. This has an interface change to restoreKeyBackup where I've changed it to take a backupInfo rather than a version (this also saves us re-fetching the backup metadata in the case of a passphrase restore).
whenever we get the SSK, ie. when creating or restoring a backup
and verify our own against our locally stored private part
because Travis and npm now have a thing where they combust if your package-lock is out of sync
or at least the rules that are consistent with the rest of our codebase
This was causing all the cross-signing stuff to fail and was almost certainly the cause of vector-im/riot-web#8213
Sp we don't stop tracking our own
* Put back babel-eslint for class-properties * Allow arrow functions without params This makes the style more consistent with react-sdk. NB. The line lengths are still inconsistent but it's not clear which way to go on that yet.
|
Right, lots more stuff fixed - ptal! |
|
Hooray, looks great! |
Co-Authored-By: J. Ryan Stinnett <jryans@gmail.com>
Co-Authored-By: J. Ryan Stinnett <jryans@gmail.com>
Co-Authored-By: J. Ryan Stinnett <jryans@gmail.com>
Co-Authored-By: J. Ryan Stinnett <jryans@gmail.com>
Co-Authored-By: J. Ryan Stinnett <jryans@gmail.com>
Co-Authored-By: J. Ryan Stinnett <jryans@gmail.com>
Co-Authored-By: J. Ryan Stinnett <jryans@gmail.com>
|
|
dbkr
added a commit
that referenced
this pull request
Nov 18, 2019
#832 added cross-signing checks for backup trust but we failed to merge in the check for the the backup being trusted locally. Fixes vector-im/riot-web#11404
jryans
added a commit
that referenced
this pull request
Dec 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
dbkr commentedFeb 1, 2019
As per matrix-org/matrix-doc#1756
There are also some things in here which will need speccing in addition to the MSC above (as it currently stands), most notably, putting the SSK & USK in the backup auth_data.