random/standard: Correctly handle broken engines in php_array_pick_keys - #13138
Merged
Conversation
TimWolla
marked this pull request as draft
January 13, 2024 13:46
Member
Author
|
Found another unhandled failure case specifically for pickArrayKeys. |
TimWolla
force-pushed
the
random-pickArrayKeys-exception
branch
from
January 13, 2024 14:20
d13cd79 to
b60b8e5
Compare
TimWolla
marked this pull request as ready for review
January 13, 2024 14:20
TimWolla
force-pushed
the
random-pickArrayKeys-exception
branch
2 times, most recently
from
January 13, 2024 14:26
fdb2b44 to
17e0c49
Compare
ndossche
reviewed
Jan 13, 2024
ndossche
left a comment
ndossche
left a comment
Member
There was a problem hiding this comment.
Code change makes sense to me, just need to check why CI fails.
TimWolla
force-pushed
the
random-pickArrayKeys-exception
branch
from
January 13, 2024 15:25
17e0c49 to
b195e50
Compare
TimWolla
added a commit
that referenced
this pull request
Jan 14, 2024
* PHP-8.2: random/standard: Correctly handle broken engines in php_array_pick_keys (#13138)
TimWolla
added a commit
that referenced
this pull request
Jan 14, 2024
TimWolla
added a commit
to TimWolla/php-src
that referenced
this pull request
May 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.