random: Fix check before closing random_fd - #10247
Merged
Merged
Conversation
If, for whatever reason, the random_fd has been assigned file descriptor `0` it previously failed to close during module shutdown, thus leaking the descriptor.
Girgias
approved these changes
Jan 7, 2023
Girgias
left a comment
Girgias
left a comment
Member
There was a problem hiding this comment.
Don't forget to update the NEWS file when merging.
TimWolla
added a commit
to TimWolla/php-src
that referenced
this pull request
Jan 7, 2023
* PHP-8.2: random: Fix check before closing `random_fd` (php#10247)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If, for whatever reason, the random_fd has been assigned file descriptor
0it previously failed to close during module shutdown, thus leaking the descriptor.