Skip to content

Fix deploy with multiple target/site in firebase.json - #8314

Merged
leoortizz merged 3 commits into
masterfrom
chalosalvador/fix-8274-config-array
Mar 12, 2025
Merged

leoortizz merged 3 commits into
masterfrom
chalosalvador/fix-8274-config-array

Conversation

@chalosalvador

Copy link
Copy Markdown
Member

Description

Fixes #8274 when using firebase.json with an array of sites/targets. Like the following:

{
  "hosting": [
    {
      "target": "static",
      "public": "public"
    },
    {
      "target": "prod",
      "source": ".",
      "ignore": [
        "firebase.json",
        "**/.*",
        "**/node_modules/**"
      ],
      "frameworksBackend": {
        "region": "europe-west1"
      }
    },
    {
      "target": "staging",
      "source": ".",
      "ignore": [
        "firebase.json",
        "**/.*",
        "**/node_modules/**"
      ],
      "frameworksBackend": {
        "region": "europe-west1"
      }
    }
  ]
}

Scenarios Tested

  • firebase.js deploy

  • firebase.js deploy --only hosting

  • firebase.js deploy --only hosting:static

  • firebase.js deploy --only hosting:prod

  • firebase.js deploy --only hosting:staging

  • firebase.js deploy --only hosting:prod,hosting:static

  • Also tested using site in firebase.json instead of target.

Sample Commands

leoortizz and others added 2 commits March 12, 2025 16:49
* refactor isDeployingWebFramework and tests

* comment

* comments

* comments

* use same tests for site and config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to deploy to firebase hosting for NextJS application, show 404 (not found) page

2 participants